Skip to content

fix(policy): name PUT group organization-memberships set_group_organization_memberships - #234

Merged
csrbarber merged 4 commits into
mainfrom
devin/1793131650-replace-group-org-memberships-hint
Oct 28, 2026
Merged

csrbarber merged 4 commits into
mainfrom
devin/1793131650-replace-group-org-memberships-hint

Conversation

@csrbarber

@csrbarber csrbarber commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

workos/workos#77785 publishes PUT /organizations/{organizationId}/groups/{groupId}/organization-memberships, which replaces every member of a group. Without a hint, oagen would name it update_group_organization_memberships. A partial-update PATCH on the same path is planned and should get update_*, so this PUT is named set_group_organization_memberships, matching the existing full-replacement PUTs set_environment_role_permissions and set_organization_role_permissions. The docs use the same name through localOperationHints in workos/workos#77783.

'PUT /organizations/{organizationId}/groups/{groupId}/organization-memberships': {
  name: 'set_group_organization_memberships',
},

This lands before the endpoint reaches the spec, so the first SDK batch already uses the right name. That avoids what happened with revoke_link (#215), which first shipped as create_revoke_link. Until the PUT is in spec/open-api-spec.yaml, the hint has no effect.

CI's build:policy check fails until #235 merges, because of the existing PUT/PATCH /authorization/groups/{group_id}/role_assignments collision. Merged locally with #235, build:policy passes.

Link to Devin session: https://app.devin.ai/sessions/8bc149a073124f0391206d32851f0baf
Open in Devin Desktop: https://app.devin.ai/desktop/session/8bc149a073124f0391206d32851f0baf?variant=devin
Requested by: @csrbarber

…ganization_memberships

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Original prompt from colin

ATTACHMENT:"https://app.devin.ai/attachments/4ff6a108-8670-4202-ac3e-8eb153cd4a55/pasted-1793119715629.txt"

@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The change appears safe to merge.

Summary

Adds set_group_organization_memberships as the name for the planned full-replacement PUT endpoint.

  • Group membership replacement gets a name that separates it from partial updates.

Reviews (4) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile

…zation_memberships

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration devin-ai-integration Bot changed the title fix(policy): name PUT group organization-memberships replace_group_organization_memberships fix(policy): name PUT group organization-memberships set_group_organization_memberships Oct 28, 2026
@csrbarber
csrbarber merged commit b8ecd35 into main Oct 28, 2026
9 checks passed
@csrbarber
csrbarber deleted the devin/1793131650-replace-group-org-memberships-hint branch October 28, 2026 13:56
gjtorikian pushed a commit that referenced this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants