Skip to content

Revert "fix(policy): name PUT group organization-memberships set_group_organization_memberships (#234)" - #239

Merged
gjtorikian merged 1 commit into
mainfrom
devin/1793211931-revert-set-group-org-memberships-hint
Oct 28, 2026
Merged

gjtorikian merged 1 commit into
mainfrom
devin/1793211931-revert-set-group-org-memberships-hint

Conversation

@csrbarber

@csrbarber csrbarber commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Reverts #234. We're dropping PUT /organizations/{organizationId}/groups/{groupId}/organization-memberships, so its set_group_organization_memberships operation hint goes too.

The PUT is still in spec/open-api-spec.yaml (synced in #238). Until it's removed from workos/workos and re-synced, merging this alone makes SDK generation name it update_group_organization_memberships. npm run build:policy passes.

Link to Devin session: https://app.devin.ai/sessions/8bc149a073124f0391206d32851f0baf
Open in Devin Desktop: https://app.devin.ai/desktop/session/8bc149a073124f0391206d32851f0baf?variant=devin
Requested by: @csrbarber

…p_organization_memberships (#234)"

This reverts commit b8ecd35.
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Original prompt from colin

ATTACHMENT:"https://app.devin.ai/attachments/4ff6a108-8670-4202-ac3e-8eb153cd4a55/pasted-1793119715629.txt"

@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change is limited to one code-generation naming hint.

Complete the PUT endpoint removal before merging.

Findings

  1. P1 Dropped endpoint stays in SDKs ▶
Fix with agent prompt
### Issue 1
src/policy/operation-hints.ts:198
Removing this hint does not drop the PUT endpoint. `spec/open-api-spec.yaml:16281` still defines it, and SDK generation reads that file without a transform that removes it. This change removes only its explicit name, so generation still includes the operation under a derived name. Remove the PUT definition alongside this hint to complete the intended endpoint removal.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Removes the set_group_organization_memberships naming hint.

  • The group-membership PUT no longer has a custom operation name.

Reviews (1) · Last reviewed commit: "Revert "fix(policy): name PUT group orga..." · Reviewed by Greptile

Comment thread src/policy/operation-hints.ts Resolved
@gjtorikian
gjtorikian merged commit 24f105e into main Oct 28, 2026
9 checks passed
@gjtorikian
gjtorikian deleted the devin/1793211931-revert-set-group-org-memberships-hint branch October 28, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants