Repository navigation
Revert "fix(policy): name PUT group organization-memberships set_group_organization_memberships (#234)" - #239
Merged
gjtorikian merged 1 commit intoOct 28, 2026
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
Original prompt from colin
|
Contributor
[Low impact] The change is limited to one code-generation naming hint. Complete the PUT endpoint removal before merging. Findings
Fix with agent prompt### Issue 1
src/policy/operation-hints.ts:198
Removing this hint does not drop the PUT endpoint. `spec/open-api-spec.yaml:16281` still defines it, and SDK generation reads that file without a transform that removes it. This change removes only its explicit name, so generation still includes the operation under a derived name. Remove the PUT definition alongside this hint to complete the intended endpoint removal.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryRemoves the
Reviews (1) · Last reviewed commit: "Revert "fix(policy): name PUT group orga..." · Reviewed by Greptile |
gjtorikian
deleted the
devin/1793211931-revert-set-group-org-memberships-hint
branch
October 28, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #234. We're dropping
PUT /organizations/{organizationId}/groups/{groupId}/organization-memberships, so itsset_group_organization_membershipsoperation hint goes too.The PUT is still in
spec/open-api-spec.yaml(synced in #238). Until it's removed fromworkos/workosand re-synced, merging this alone makes SDK generation name itupdate_group_organization_memberships.npm run build:policypasses.Link to Devin session: https://app.devin.ai/sessions/8bc149a073124f0391206d32851f0baf
Open in Devin Desktop: https://app.devin.ai/desktop/session/8bc149a073124f0391206d32851f0baf?variant=devin
Requested by: @csrbarber