Repository navigation
fix(policy): name POST /portal/revoke_link revoke_link - #215
Merged
Merged
Conversation
Contributor
Author
|
Paired Node PR: workos/workos-node#1726 |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummarySets the shared name for
Reviews (1) · Last reviewed commit: "fix(policy): name POST /portal/revoke_li..." · Reviewed by Greptile |
Without a hint the resolver derives `create_revoke_link` for the new Admin Portal operation. Mirror the existing `generate_link` hint. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ajworkos
force-pushed
the
adam/revoke-link-naming
branch
from
October 15, 2026 12:11
e07fa24 to
c95cff2
Compare
ajworkos
added a commit
to workos/workos-node
that referenced
this pull request
Oct 15, 2026
… OpenAPI spec Generated with oagen (--services AdminPortal) against the policy in workos/openapi-spec#215. generateLink now takes externalUserId and itContactEmails; adminEmails and intentOptions are gone because the API dropped admin_emails in April and hides intent_options from the spec. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ajworkos
added a commit
to workos/workos-node
that referenced
this pull request
Oct 15, 2026
… OpenAPI spec Generated with oagen (--services AdminPortal) against the policy in workos/openapi-spec#215. generateLink now takes externalUserId and itContactEmails; adminEmails and intentOptions are gone because the API dropped admin_emails in April and hides intent_options from the spec. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I shipped
POST /portal/revoke_linkin workos/workos#74530. The spec reached this repo in #214 and the Oct 14 batch generated it into every SDK ascreate_revoke_link/CreateRevokeLink, because oagen names methods from the URL path and onlygenerate_linkhad a hint. The seven open generated PRs (python #747, go #632, ruby #562, php #452, dotnet #320, kotlin #450, rust #165) carry that name and need a fresh batch after this merges.Proof
sdk:generate --lang node --services AdminPortalwith this hint emitsrevokeLink(options: RevokeLinkOptions); that output is feat(admin-portal)!: add revokeLink and generate the service from the OpenAPI spec workos-node#1726.npm test: 146 pass, 0 fail.🤖 Generated with Claude Code