Skip to content

fix(policy): name POST /portal/revoke_link revoke_link - #215

Merged
gjtorikian merged 1 commit into
mainfrom
adam/revoke-link-naming
Oct 15, 2026
Merged

gjtorikian merged 1 commit into
mainfrom
adam/revoke-link-naming

Conversation

@ajworkos

@ajworkos ajworkos commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Why

I shipped POST /portal/revoke_link in workos/workos#74530. The spec reached this repo in #214 and the Oct 14 batch generated it into every SDK as create_revoke_link / CreateRevokeLink, because oagen names methods from the URL path and only generate_link had a hint. The seven open generated PRs (python #747, go #632, ruby #562, php #452, dotnet #320, kotlin #450, rust #165) carry that name and need a fresh batch after this merges.

Proof

🤖 Generated with Claude Code

@ajworkos

Copy link
Copy Markdown
Contributor Author

Paired Node PR: workos/workos-node#1726

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Sets the shared name for POST /portal/revoke_link to revoke_link.

  • The revoke-link route now produces a revoke_link method.
  • Node's generate-link types keep fields hidden or renamed by the spec.

Reviews (1) · Last reviewed commit: "fix(policy): name POST /portal/revoke_li..." · Reviewed by Greptile

Without a hint the resolver derives `create_revoke_link` for the new
Admin Portal operation. Mirror the existing `generate_link` hint.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@ajworkos
ajworkos force-pushed the adam/revoke-link-naming branch from e07fa24 to c95cff2 Compare October 15, 2026 12:11
@ajworkos ajworkos changed the title fix(policy): name POST /portal/revoke_link revoke_link; hand-own Node GenerateLink fix(policy): name POST /portal/revoke_link revoke_link Oct 15, 2026
ajworkos added a commit to workos/workos-node that referenced this pull request Oct 15, 2026
… OpenAPI spec

Generated with oagen (--services AdminPortal) against the policy in
workos/openapi-spec#215. generateLink now takes externalUserId and
itContactEmails; adminEmails and intentOptions are gone because the API
dropped admin_emails in April and hides intent_options from the spec.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ajworkos added a commit to workos/workos-node that referenced this pull request Oct 15, 2026
… OpenAPI spec

Generated with oagen (--services AdminPortal) against the policy in
workos/openapi-spec#215. generateLink now takes externalUserId and
itContactEmails; adminEmails and intentOptions are gone because the API
dropped admin_emails in April and hides intent_options from the spec.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@ajworkos
ajworkos requested a review from gjtorikian October 15, 2026 12:19
@gjtorikian
gjtorikian merged commit 460c023 into main Oct 15, 2026
7 checks passed
@gjtorikian
gjtorikian deleted the adam/revoke-link-naming branch October 15, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants