Repository navigation
fix(doctor,scan): report ignored koru runtime files that are still tracked (ticket-442) - #702
Conversation
…acked (ticket-442) A .gitignore entry does not untrack files committed earlier, so seven repositories keep .koru/event-store.jsonl and .koru/events/* tracked and every koru run dirties their primary checkout. check_gitignore now warns and scan_gitignore_drift suggests 'git rm --cached' for them. Co-Authored-By: Claude <noreply@anthropic.com>
772051c to
4c19576
Compare
There was a problem hiding this comment.
Validator approval after policy checks for exact head 4c1957692d40a2f4d2edc65019cb9afe524653c9.
Ticket: ticket-442
Correlation ID: local-semcod-koru-pr-702-ticket-442
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). The implementation correctly detects ignored-but-tracked runtime files under .koru and .planfile/.koru, reports them through doctor and scan without automatically modifying repositories, and includes focused coverage for tracked, untracked, and non-Git cases. All protected required checks passed.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 1d9ff59e6fa782444a86d3f6f0131480ad63e12e...4c1957692d40a2f4d2edc65019cb9afe524653c9
Change digest: 01b8cf7e44ec439b6e3edd0b3a2c52ade47320e1e4ddd3496c5c4c9b28cd1042
Score: 64/100 (L), estimated 94 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":207,"base_sha":"1d9ff59e6fa782444a86d3f6f0131480ad63e12e","binary_files":0,"categories":{"code":2,"configuration":1,"docs":1,"tests":1},"change_digest":"01b8cf7e44ec439b6e3edd0b3a2c52ade47320e1e4ddd3496c5c4c9b28cd1042","comparison":"1d9ff59e6fa782444a86d3f6f0131480ad63e12e...4c1957692d40a2f4d2edc65019cb9afe524653c9","deletions":4,"file_count":5,"files":["project/ticket-442/README.md","project/ticket-442/intent.json","src/koru/doctor_project_health.py","src/koru/scan.py","tests/test_doctor_tracked_runtime.py"],"head_sha":"4c1957692d40a2f4d2edc65019cb9afe524653c9","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":2,"scope":5,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":94,"within_budget":false},"impact":{"components":["claude.com","coru-agent","koru","planfile","project","semcod","src/koru","subactor","tests"],"files":["claude.com/claude-code","coru-agent/coru-dev","koru/event-store.jsonl","koru/events","planfile/.koru","project/ticket-442/README.md","project/ticket-442/intent.json","semcod/prefact","src/koru/doctor_project_health.py","src/koru/scan.py","subactor/orchestrator","tests/test_doctor_tracked_runtime.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":64,"split":{"parts":[{"estimated_minutes":10,"name":"Implement claude.com","scope":["claude.com"]},{"estimated_minutes":10,"name":"Implement coru-agent","scope":["coru-agent"]},{"estimated_minutes":10,"name":"Implement koru","scope":["koru"]},{"estimated_minutes":10,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":10,"name":"Implement project","scope":["project"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-442"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-442: fix(doctor,scan): report ignored koru runtime files that are still tracked (ticket-442)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 105,51 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 94m</text></svg>DECISION D-442-0931
TICKET ticket-442
HEAD_SHA 4c1957692d40a2f4d2edc65019cb9afe524653c9
CORRELATION_ID local-semcod-koru-pr-702-ticket-442
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / enforce=PASS","governance / remote lifecycle=PASS","standard packs / conformance=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","standard packs / conformance"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/koru","pull_request":702,"head_sha":"4c1957692d40a2f4d2edc65019cb9afe524653c9","base_sha":"1d9ff59e6fa782444a86d3f6f0131480ad63e12e","diff_sha256":"ae19285dae5da10c5e40060ef04f44bb2a532a1751531979eabfb833eee99608"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/ticket-442/README.md","project/ticket-442/intent.json","src/koru/doctor_project_health.py","src/koru/scan.py","tests/test_doctor_tracked_runtime.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = ["smoke"]
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"1d9ff59e6fa782444a86d3f6f0131480ad63e12e","head_sha":"4c1957692d40a2f4d2edc65019cb9afe524653c9","change_digest":"01b8cf7e44ec439b6e3edd0b3a2c52ade47320e1e4ddd3496c5c4c9b28cd1042","score":64,"complexity":"L","estimated_minutes":94,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Problem
.koru/is in.gitignorein semcod/prefact, repatch, tagi, nxdo, subactor/orchestrator and coru-agent/coru-dev, but.koru/event-store.jsonland.koru/events/*were committed before that entry. Git keeps tracking them, so every koru run leaves the primary checkout dirty, which blocks work-start / worktree admission (LIM-WORKTREE-004).koru doctor/scanonly checked that the.gitignoreline exists.Change
tracked_ignored_runtime_files()(git ls-files -ci --exclude-standard -- .koru .planfile/.koru).check_gitignore→ WARN with agit rm --cachedhint;scan_gitignore_drift→ a hygiene suggestion listing the files.Evidence
Real repositories: prefact 4, tagi 11, orchestrator 15 files reported. Tests: 127 passed (3 new); Ruff clean on changed files; governance GOV-PASS.
Ticket: ticket-442
🤖 Generated with Claude Code