Skip to content

test(queue): give the unmanaged-workspace test its own Git identity (ticket-443) - #703

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/443-give-the-unmanaged-workspace-queue-test-its-own-git-identity
Oct 7, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/443-give-the-unmanaged-workspace-queue-test-its-own-git-identity

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

test_unmanaged_workspace_and_scan_artifacts (added in 06648f2) commits with the global Git identity. The OneDev executor runs as nobody without one:

fatal: unable to auto-detect email address (got 'nobody@cc9bed392ed7.(none)')
FAILED tests/test_planfile_queue.py::test_unmanaged_workspace_and_scan_artifacts

This fails onedev/local-verify for every koru PR (e.g. #702). The fix passes -c user.name/-c user.email like the other tests in the file. Verified with HOME=$(mktemp -d); governance GOV-PASS.

Ticket: ticket-443

🤖 Generated with Claude Code

…ticket-443)

The seed commit relied on a global Git identity. The OneDev executor runs as
'nobody' without one, so onedev/local-verify failed for every koru PR.

Co-Authored-By: Claude <noreply@anthropic.com>

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head bffa1207b7ae67e030491a8c2e0bfecc2f7814e7.

Ticket: ticket-443
Correlation ID: local-semcod-koru-pr-703-ticket-443
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 1 diff chunk(s). The Git identity fix is correctly scoped and the required checks pass, but the ticket index update is inconsistent with the newly added ticket.
Advisory findings: project/TICKETS.md adds ticket-441 while this change creates and documents ticket-443. Update the index to register ticket-443, or explain and separately include the missing ticket-441 artifacts if that entry is intentional.
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 06648f2a1bacdd4254669d522ff2b9471323b658...bffa1207b7ae67e030491a8c2e0bfecc2f7814e7
Change digest: 22e60d983d8653e604f7dd858c19d5504e1610613cb8c038a23a62d690cdebf3
Score: 56/100 (L), estimated 61 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":106,"base_sha":"06648f2a1bacdd4254669d522ff2b9471323b658","binary_files":0,"categories":{"configuration":1,"docs":2,"tests":1},"change_digest":"22e60d983d8653e604f7dd858c19d5504e1610613cb8c038a23a62d690cdebf3","comparison":"06648f2a1bacdd4254669d522ff2b9471323b658...bffa1207b7ae67e030491a8c2e0bfecc2f7814e7","deletions":1,"file_count":4,"files":["project/TICKETS.md","project/ticket-443/README.md","project/ticket-443/intent.json","tests/test_planfile_queue.py"],"head_sha":"bffa1207b7ae67e030491a8c2e0bfecc2f7814e7","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":2,"scope":3,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":61,"within_budget":false},"impact":{"components":["claude.com","onedev","project","tests","user.name"],"files":["claude.com/claude-code","onedev/local-verify","project/TICKETS.md","project/ticket-443/README.md","project/ticket-443/intent.json","tests/test_planfile_queue.py","user.name/-c"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":56,"split":{"parts":[{"estimated_minutes":11,"name":"Implement claude.com","scope":["claude.com"]},{"estimated_minutes":11,"name":"Implement onedev","scope":["onedev"]},{"estimated_minutes":11,"name":"Implement project","scope":["project"]},{"estimated_minutes":11,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":11,"name":"Implement user.name","scope":["user.name"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-443"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-443: test(queue): give the unmanaged-workspace test its own Git identity (ticket-443)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 105,51 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 61m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-443-7380
TICKET ticket-443
HEAD_SHA bffa1207b7ae67e030491a8c2e0bfecc2f7814e7
CORRELATION_ID local-semcod-koru-pr-703-ticket-443
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["standard packs / conformance=PASS","governance / enforce=PASS","governance / remote lifecycle=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","standard packs / conformance"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/koru","pull_request":703,"head_sha":"bffa1207b7ae67e030491a8c2e0bfecc2f7814e7","base_sha":"06648f2a1bacdd4254669d522ff2b9471323b658","diff_sha256":"fa5ced6e665ad7b8ff326d149a7b62c6972e1cc101031088ab3b7685d0fe3a80"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/TICKETS.md","project/ticket-443/README.md","project/ticket-443/intent.json","tests/test_planfile_queue.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = ["smoke"]
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"06648f2a1bacdd4254669d522ff2b9471323b658","head_sha":"bffa1207b7ae67e030491a8c2e0bfecc2f7814e7","change_digest":"22e60d983d8653e604f7dd858c19d5504e1610613cb8c038a23a62d690cdebf3","score":56,"complexity":"L","estimated_minutes":61,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit 1d9ff59 into main Oct 7, 2026
5 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/443-give-the-unmanaged-workspace-queue-test-its-own-git-identity branch October 7, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant