Repository navigation
[2/4] Keep chat preference changes immediate with safe background saves - #453
Draft
Sheng Chen (jdneo) wants to merge 1 commit into
Draft
Sheng Chen (jdneo) wants to merge 1 commit into
Sheng Chen (jdneo) wants to merge 1 commit into
Conversation
Centralize revisioned account-bound snapshots and a coalescing serialized writer. Keep UI choices active after failures with localized retry, and atomically replace complete preference documents while preserving supported protections. On POSIX filesystems without an ACL view, retain owner/group identity and owner permission bits while removing group/other access, as approved to prevent unverified extended ACLs from broadening access. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 20, 2026
Sheng Chen (jdneo)
added this pull request to stack #456
September 20, 2026 10:31
Sheng Chen (jdneo)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Layer 02 of the nonblocking preference work. Parent: #452.
Base:
jdneo-preferences-01-nonblocking-loadingat450bb7814e20b8e8143ecd4c8aa6d40a05129d2a(notmain). Do not merge independently of the stack.Changes
Approved POSIX protection clarification
Standard Java 17 cannot reliably inspect/preserve Linux extended POSIX ACLs. On POSIX filesystems without a supported ACL view, replacement therefore preserves the original owner/group identity and OWNER permission bits while removing GROUP/OTHERS access. This intentionally narrows group/ACL sharing, which may stop working; same-OS-user multi-instance last-completed-save behavior is retained. Full extended ACL preservation is not claimed. Supported Windows ACL preservation is unchanged, and inability to apply required protections fails without replacing the original target.
Automatic authentication/reconnection recovery and the bounded workbench shutdown flush belong to later stack layers and are not included.
Validation
All final commands passed with Java 21 and
-Dtycho.disableP2Mirrors=true:.\mvnw.cmd -B '-Dtycho.disableP2Mirrors=true' clean verify.\mvnw.cmd -B '-Dtycho.disableP2Mirrors=true' checkstyle:check.\mvnw.cmd -B '-Dtycho.disableP2Mirrors=true' testFull verify: 10,800 tests, zero failures/errors, 8 POSIX-only tests skipped on Windows. SWTBot probe module skips by default; no probe execution is claimed. Tests cover real UI/event responsiveness under delayed saves, coalescing/in-flight revisions, failure/retry, history, account-transition publication, disposal, complete files, replacement failures and Windows ACL preservation.
Review
Parallel Standards/Spec review against the parent SHA: Standards reported no findings. Spec identified an auth-transition publication race (fixed with a reproduced regression) and the extended-ACL limitation (addressed by the explicitly approved conservative POSIX policy above).