Repository navigation
[3/4] Recover preferences on login and CLS reconnection - #454
Draft
Sheng Chen (jdneo) wants to merge 1 commit into
Draft
Sheng Chen (jdneo) wants to merge 1 commit into
Sheng Chen (jdneo) wants to merge 1 commit into
Conversation
Retry unsuccessful preference and mode initialization on real lifecycle transitions while preserving ready choices and account-bound saves. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sheng Chen (jdneo)
added this pull request to stack #456
September 20, 2026 10:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Layer 3 of 4 for nonblocking Eclipse chat preferences (#408). Depends on #453; base is
jdneo-preferences-02-safe-background-savesat139798b0db72bb8fc9b3fe3aa356dfb03545eb02. Bottom layer: #452. Implements only ticket 03 of the approved local specification; bounded shutdown saving remains for layer 4.Changes
StreamConnectionProvider.handleMessagehook after the outgoinginitializednotification. LSP4E reaches this only after successful initialization and creates a fresh provider on restart. Deduplicate per provider and identify each connection incarnation; do not infer reconnection from authentication notifications or poll.Verification
TDD red/green regressions cover login, actual initialized-message-to-controls recovery with SWT responsiveness, failed mode discovery, duplicate notifications, manual/recovery races, stale timed-out responses, account switching during saves, signed-out/disposed signals, and rapid same-account sign-out/sign-in with real AuthStatusManager.
All commands used command-local
JAVA_HOME=C:\Users\sheche\.jdks\ms-21.0.11and-B -Dtycho.disableP2Mirrors=true:verify: preference/storage/model/chat-base/referenced-file tests and authentication/stream-provider tests passed.mvnw.cmd clean verify: passed; 10,810 tests, 0 failures, 0 errors, 8 skips.mvnw.cmd checkstyle:check: passed.mvnw.cmd test: passed (Tycho executes the actual test suites duringverify).Eight POSIX-specific tests are skipped on Windows; no Linux execution claim. SWTBot probe suite remains skipped by default; the new SWT lifecycle/control tests execute in the Eclipse JUnit test bundle.
Parallel Standards/Spec reviews against the exact layer 2 baseline found no blocking issues and no missing ticket requirements. Standards noted only an existing documentation/API inconsistency: docs prescribe a nonexistent
logErrorhelper; this change follows the actual repositoryLOGGERconvention.