Repository navigation
display: shared cabinet outputs and plug-in system defaults - #615
Merged
Merged
Conversation
Add immutable output plans, consumer eligibility, and owned SDR copy targets. Share provider ranking and skip incompatible scene surfaces. Include contract, GPU-copy, and native-window probes.
… output from the cabinet contract Physical DMD panels are no longer player destinations, so cabinet targets are desktop regions only and assignments are keyed by plug-in and role. The import of plug-in saved window positions is gone. The full DMD scene surface stays for the plug-in that publishes it.
IPluginSystemDefaults lets a plug-in describe what it takes from other applications on this computer while its own settings are empty: folders, configuration files and the output placements they suggest. The Player shows them on its first start without knowing the plug-in, and the user can replace each one with the player's own value. Only read, never written back.
[Medium impact] The documentation update appears safe to merge. SummaryAdds shared cabinet output contracts, plug-in system defaults, transformed texture copies, and packaging support for collision-only playfields.
Reviews (2) · Last reviewed commit: "doc: Full DMD isn't a cabinet output rol..." · Reviewed by Greptile |
The guide still listed FullDmd as a role, and device profiles and import candidates as enum users, though the contract dropped them. A plug-in that publishes a Full DMD surface opens its own window, and old full-dmd layout records are dropped on load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine side of the player's cabinet display setup and first-start welcome screen. The display plug-ins (DMD, B2S, PinUP, Kiki) build on these contracts and are already on their master/main, and the Player and PinMAME PRs need this one.
CabinetDisplays): output plans with known cabinet roles, which plug-ins may provide each role, and copy targets the player owns. Cabinet targets are desktop regions only, and assignments are keyed by plug-in and role. Physical DMD panels are no longer player destinations, and the import of the plug-ins' saved window positions is gone. The full DMD scene surface stays for the plug-in that publishes it.CabinetOutputTextureand its shader make transformed copies (rotation, mirroring) and inset composition.CabinetSurfaceSelectorshares the provider ranking and skips scene surfaces that don't fit. The screen binder takes a provider order per role.IPluginSystemDefaults): a plug-in can describe what it takes from other applications on this computer while its own settings are empty: folders, configuration files and the output placements they suggest. The player shows them on its first start without knowing the plug-in, and the user can replace each one with the player's own value. They are only read, never written back.Tests:
CabinetDisplayTests,CabinetOutputTextureTests,CabinetNativeWindowTestsand more cases inPlayfieldMeshPackagingTests. The developer guide has a new page on cabinet display outputs.