Repository navigation
plugin: report Visual PinMAME's folders as system defaults - #51
Merged
Merged
Conversation
…defaults The Player's first-start setup shows where PinMAME's nvram and AltSound folders come from when the plug-in's own settings are empty. Only read, never written back.
 [Low impact] The PR appears safe to merge; both previous findings are fixed. SummaryThe plug-in reports Visual PinMAME’s saved-game and AltSound folders for the welcome screen.
Reviews (2) · Last reviewed commit: "plugin: report AltSound packs from every..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
AltSound looks for a game's pack in VPinMAME's folder and in VPE's, so the welcome screen counts the packs in both and names the other folder. Finding the defaults no longer creates PinMAME's data folders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plug-in now implements
IPluginSystemDefaults(freezy/VisualPinball.Engine#615). It reports Visual PinMAME's saved games (nvram) and AltSound folders, so the player's welcome screen can show where they come from while the plug-in's own settings are empty. They are only read, never written back.