Tests: local HCAT fixtures and command-module smoke test - #329
Merged
Merged
Conversation
ivorbosloper
marked this pull request as ready for review
September 24, 2026 20:29
ivorbosloper
changed the title
…e smoke test The test loader patch that reads these fixtures landed with #320. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ivorbosloper
changed the title
ivorbosloper
force-pushed
the
test-wiring
branch
from
September 25, 2026 10:32
8481e71 to
8b07807
Compare
m-mohr
approved these changes
Sep 25, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The registry smoke test does not cover all 13 registered commands.
Review effort: Lite
Findings: None
What changed in this PR
Adds local HCAT mapping fixtures for four converters and smoke tests for command modules and registry setup.
Changes:
- Adds Ireland, Italy, Sweden, and California mapping fixtures.
- Adds command import and registry smoke tests.
- Ignores
build/artifacts. - Registry coverage should include all 13 registered commands.
| File | Summary |
|---|---|
tests/test_command_modules.py |
Tests command imports and registry registration; coverage currently includes only four of 13 commands. |
tests/data-files/convert/us_ca_scm/scm.csv |
Adds California HCAT mapping fixture. |
tests/data-files/convert/se/se.csv |
Adds Sweden HCAT mapping fixture. |
tests/data-files/convert/it_1/iti1.csv |
Adds Italy HCAT mapping fixture. |
tests/data-files/convert/ie/ie.csv |
Adds Ireland HCAT mapping fixture. |
.gitignore |
Ignores build/ artifacts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds local HCAT mapping fixtures for four converters so their tests no longer fetch the mapping online, plus a smoke test for the command wrapper modules.
ie/ie.csv,it_1/iti1.csv,se/se.csv,us_ca_scm/scm.csvare named after each converter'shcat_mapping_csv, so the loader patch intests/test_convert.py(which came with Rename AddHCATMixin attributes #285 #320) picks them up.ie/ie.csvsits next to, not in place of,ie_lpis/ie.csvfrom IE: add ie_lpis, DAFM's Anonymous LPIS parcels for 2017-2022 and 2025. #310.tests/test_command_modules.pychecks that the one-line command modules import and that the registry registers the fiboa commands..gitignoreignoresbuild/.🤖 Generated with Claude Code