EC-FR, EC-NL-CROP: override the EuroCrops rows that disagree with the taxonomy - #330
Merged
Merged
Conversation
ivorbosloper
force-pushed
the
ec-nl-fr-supplements
branch
from
September 25, 2026 10:24
01d9b92 to
8c19582
Compare
… taxonomy - ec_nl_crop and ec_fr read the new nl_2020 and fr_2018 supplements - a source that already carries HCAT (the EuroCrops shapefiles) now gets its supplement applied too, keyed on the crop code; so far ec_si's supplement was never read Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ivorbosloper
force-pushed
the
ec-nl-fr-supplements
branch
from
September 25, 2026 10:27
8c19582 to
9500192
Compare
- test_hcat_codes builds each converter's table with its supplements, so KNOWN_BAD can go; fixtures refreshed from fiboa.org where they were stale - pixi run check-hcat runs the same check against the published tables Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The central HCAT name-correction behavior remains untested, and the changelog inaccurately describes the parsley correction.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Applies HCAT supplement corrections to EuroCrops datasets that already contain resolved HCAT fields.
Changes:
- Adds source-resolved HCAT supplement handling.
- Configures French, Dutch, and Slovenian EuroCrops supplements.
- Adds a French fixture and correction test.
| File | Description |
|---|---|
fiboa_cli/datasets/commons/hcat.py |
Applies supplements to existing HCAT columns. |
fiboa_cli/datasets/ec_fr.py |
Configures the French supplement. |
fiboa_cli/datasets/ec_nl_crop.py |
Configures the Dutch supplement. |
fiboa_cli/datasets/ec_si.py |
Applies supplements using Slovenia’s crop key. |
tests/test_converters.py |
Tests source-resolved HCAT correction. |
tests/data-files/convert/ec_fr/fr_2018_supplement.csv |
Adds the French correction fixture. |
CHANGELOG.md |
Documents the corrections. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Check the HCAT tables as the converters apply them, online too
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ivorbosloper
marked this pull request as ready for review
September 25, 2026 13:16
m-mohr
approved these changes
Sep 25, 2026
m-mohr
left a comment
m-mohr
left a comment
Contributor
There was a problem hiding this comment.
As far as I can judge it, it looks good.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Network failures can crash the new checker, and the EC-NL-CROP override lacks automated coverage.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 3
Open (3)
…each Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes HCAT handling and testing, resolves #304
Depends on fiboa/fiboa.github.io#29