Fix PER-CS blank line between import groups being stripped

blink/internal/fixer/rules/priorities.go

@@ -158,7 +158,7 @@ var fixerPriority = map[string]int{
 	"SingleClassElementPerStatementFixer":             56,
 	"SingleImportPerStatementFixer":                   1,
 	"SingleLineAfterImportsFixer":                     -11,
-	"NoBlankLineBetweenImportsFixer":                  -50,
+	"NoBlankLineBetweenImportsFixer":                  -35,
 	"SpaceAfterCommaHereNowDocFixer":                  0,
 	"ArrayOpenerAndCloserNewlineFixer":                34,
 	"SingleLineCommentSpacingFixer":                   1,

packages/coding-standard/src/Fixer/Spacing/NoBlankLineBetweenImportsFixer.php

@@ -29,10 +29,10 @@ public function getDefinition(): FixerDefinitionInterface
         return new FixerDefinition(self::ERROR_MESSAGE, [new CodeSample("<?php\nuse Foo\\Bar;\n\nuse function Foo\\baz;\n")]);
     }
 
-    // run after OrderedImportsFixer and BlankLineBetweenImportGroupsFixer
+    // run after OrderedImportsFixer, before BlankLineBetweenImportGroupsFixer
     public function getPriority(): int
     {
-        return -50;
+        return -35;
     }
 
     /**

packages/coding-standard/tests/Fixer/Spacing/NoBlankLineBetweenImportsFixer/NoBlankLineBetweenImportsFixerWithImportGroupsTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\CodingStandard\Tests\Fixer\Spacing\NoBlankLineBetweenImportsFixer;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Symplify\EasyCodingStandard\Testing\PHPUnit\AbstractCheckerTestCase;
+
+final class NoBlankLineBetweenImportsFixerWithImportGroupsTest extends AbstractCheckerTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFiles(__DIR__ . '/WithImportGroupsFixture');
+    }
+
+    public function provideConfig(): string
+    {
+        return __DIR__ . '/config/with_import_groups_rule.php';
+    }
+}

packages/coding-standard/tests/Fixer/Spacing/NoBlankLineBetweenImportsFixer/WithImportGroupsFixture/add_blank_line_between_import_groups.php.inc

@@ -0,0 +1,28 @@
+<?php
+
+namespace Symplify\CodingStandard\Tests\Fixer\Spacing\NoBlankLineBetweenImportsFixer\WithImportGroupsFixture;
+
+use Foo\Bar;
+use Foo\Baz;
+use function Foo\baz;
+
+class AddBlankLineBetweenImportGroups
+{
+}
+
+?>
+-----
+<?php
+
+namespace Symplify\CodingStandard\Tests\Fixer\Spacing\NoBlankLineBetweenImportsFixer\WithImportGroupsFixture;
+
+use Foo\Bar;
+use Foo\Baz;
+
+use function Foo\baz;
+
+class AddBlankLineBetweenImportGroups
+{
+}
+
+?>

packages/coding-standard/tests/Fixer/Spacing/NoBlankLineBetweenImportsFixer/WithImportGroupsFixture/keep_blank_line_between_import_groups.php.inc

@@ -0,0 +1,30 @@
+<?php
+
+namespace Symplify\CodingStandard\Tests\Fixer\Spacing\NoBlankLineBetweenImportsFixer\WithImportGroupsFixture;
+
+use Foo\Bar;
+
+use Foo\Baz;
+
+use function Foo\baz;
+
+class KeepBlankLineBetweenImportGroups
+{
+}
+
+?>
+-----
+<?php
+
+namespace Symplify\CodingStandard\Tests\Fixer\Spacing\NoBlankLineBetweenImportsFixer\WithImportGroupsFixture;
+
+use Foo\Bar;
+use Foo\Baz;
+
+use function Foo\baz;
+
+class KeepBlankLineBetweenImportGroups
+{
+}
+
+?>

packages/coding-standard/tests/Fixer/Spacing/NoBlankLineBetweenImportsFixer/config/with_import_groups_rule.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+use PhpCsFixer\Fixer\Whitespace\BlankLineBetweenImportGroupsFixer;
+use Symplify\CodingStandard\Fixer\Spacing\NoBlankLineBetweenImportsFixer;
+use Symplify\EasyCodingStandard\Config\ECSConfig;
+
+return static function (ECSConfig $ecsConfig): void {
+    $ecsConfig->rule(BlankLineBetweenImportGroupsFixer::class);
+    $ecsConfig->rule(NoBlankLineBetweenImportsFixer::class);
+};