Repository navigation
Fix PER-CS blank line between import groups being stripped - #206
Merged
TomasVotruba merged 2 commits intoOct 13, 2026
Merged
Conversation
…sFixer Priority -50 ran after BlankLineBetweenImportGroupsFixer (-40), stripping the PER-CS blank line between import groups. Raise to -35 so it runs after OrderedImportsFixer but before the group fixer, keeping the group blank line.
Keep the blink Go engine in parity with the PHP fixer by running NoBlankLineBetweenImportsFixer before BlankLineBetweenImportGroupsFixer.
TomasVotruba
enabled auto-merge (squash)
October 13, 2026 13:30
TomasVotruba
deleted the
fix-blank-line-between-import-groups-priority
branch
October 13, 2026 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ecsphp/ecs#336
NoBlankLineBetweenImportsFixerran at priority-50, afterBlankLineBetweenImportGroupsFixer(-40). In thePER_CSset the group fixer adds the required blank line between import groups (class vsuse function/use const), then this fixer removed it again, soBlankLineBetweenImportGroupsFixerwas effectively a no-op.Raise the priority to
-35: still afterOrderedImportsFixer(-30), now beforeBlankLineBetweenImportGroupsFixer(-40). The fixer collapses blank lines between consecutiveusestatements first, then the group fixer re-adds the single blank line between groups. Result matches PER Coding Style v3.1 rule 3.Added a regression test composing both fixers that covers keeping an existing group blank line and adding a missing one.