Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/decisions_reconcile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Reconcile of the Current Decisions pages (docs/decisions/)
# =============================================================================
# Runs the `eng-adr reconcile` skill of chainloop-dev/brain with Claude Code.
# Runs on weekdays, and on a manual start. When the pages change, it opens or updates one draft PR.
# Runs on weekdays, and on a manual start. When the pages change, it opens or updates one PR, ready for review.
#
# The skill runs in its scheduled mode: it asks no questions, writes only the
# changes that need no person, and lists the open questions in the PR body.
Expand Down Expand Up @@ -342,5 +342,5 @@ jobs:
labels: |
automated
skip-ai-session
draft: true
draft: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This does not transition the existing reconcile PR from draft to ready: create-pull-request does not use draft: false as an update-time ready-for-review transition. Because this workflow reuses decisions-reconcile-scheduled, the first run after this change updates the old draft and reviewers still receive no notification; add a one-time gh pr ready/GraphQL transition (or migrate the existing PR) in addition to setting the create mode.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/decisions_reconcile.yml, line 345:

<comment>This does not transition the existing reconcile PR from draft to ready: `create-pull-request` does not use `draft: false` as an update-time ready-for-review transition. Because this workflow reuses `decisions-reconcile-scheduled`, the first run after this change updates the old draft and reviewers still receive no notification; add a one-time `gh pr ready`/GraphQL transition (or migrate the existing PR) in addition to setting the create mode.</comment>

<file context>
@@ -342,5 +342,5 @@ jobs:
             automated
             skip-ai-session
-          draft: true
+          draft: false
           delete-branch: true
</file context>

delete-branch: true
Loading