Skip to content

ci(decisions): open the reconcile PR ready for review - #3835

Open
migmartri wants to merge 1 commit into
mainfrom
ci/decisions-reconcile-ready-pr
Open

migmartri wants to merge 1 commit into
mainfrom
ci/decisions-reconcile-ready-pr

Conversation

@migmartri

@migmartri migmartri commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

The scheduled reconcile workflow of the Current Decisions pages now opens its PR ready for review, not as a draft. A draft PR does not notify the requested reviewers (the area owners), so each run needed a person to mark it ready by hand.

This change was made with AI assistance (Claude Code).

🤖 Posted by Maximus bot (Claude Code) on behalf of @migmartri

View guided diff

The scheduled reconcile of the Current Decisions pages opened its PR as a
draft, so the area owners did not get a review request until somebody
marked it ready by hand.

Assisted-by: Claude Code
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>

Chainloop-Trace-Sessions: 039efc78-9c27-4cb0-9f54-1004200a1c5d
@chainloop-platform

chainloop-platform Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

PR validation — ⚠️ 1 failing

Status Policy Material Messages
✅ Passed pr-min-approvals pr-info -
✅ Passed pr-description-required pr-info -
⚠️ Failed pr-user-story-linked pr-info PR/MR #3835 does not reference a user story or issue in title, description, or branch 'ci(decisions): open the reconcile PR ready for review'. Expected patterns: ["(?i)[A-Z]+-[0-9]+", "#[0-9]+", "(?i)gh-[0-9]+", "(?i)\\[[A-Z]+-[0-9]+\\]"]

View attestation ↗

AI Session Checks — 🟡 60% · ✅ 0 failing

Avg score Sessions Failing policies Attribution Files Lines Total Duration
🟡 60% 1 ✅ 0 100% AI / 0% Human 1 +2 / -2 1m19s

🟡 60% — 100% AI — ✅ All policies passing

Nov 19, 2026 16:03 UTC · 1m19s · $2.02 · 72 in / 10.3k out · claude-code 2.1.328 (claude-opus-5-5)

View session details ↗

Change Summary

Changes scheduled decisions-reconciliation PR creation from draft to ready for review. Updates the workflow comment to match that behavior.

AI Session Overall Score

🟡 60% — Focused one-shot workflow fix remains unexercised; review-readiness verification needs attention.

AI Session Analysis Breakdown

🟢 98% · scope-discipline

🟢 The diff confines changes to draft status and its matching comment, with no unrelated workflow edits. · High Impact

🟢 96% · solution-quality

🟢 Changing the PR-creation setting directly removes the recurring cause without adding a post-creation workaround. · High Impact

🟢 92% · alignment

🟢 The AI disclosed fixing this worktree first; the diff changes draft status exactly as described. · High Impact

🟢 92% · context-and-planning

No notes.

🔴 35% · verification

🔴 After changing draft status, the captured session proceeds directly to commit and push without exercising the updated workflow. · High Severity

💡 For workflow changes, run the updated workflow on an appropriate test branch and inspect the resulting PR readiness before declaring verification complete.

🟡 This one-shot session has no follow-up user confirmation; that signal is not applicable, rather than failed. · Low Severity

abstained · user-trust-signal

🟡 user-trust-signal not assessed — reviewer should confirm coverage · Low Severity


File Attribution

████████████████████ 100% AI / 0% Human

Status Attribution File Lines
modified ai .github/workflows/decisions_reconcile.yml +2 / -2

Policies (4)

Status Policy Material Messages
✅ Passed ai-config-no-secrets ai-coding-session-039efc -
✅ Passed ai-config-mcp-servers-allowed ai-coding-session-039efc -
✅ Passed ai-config-ai-agents-allowed ai-coding-session-039efc -
✅ Passed ai-config-no-dangerous-commands ai-coding-session-039efc -

Security Checks — ✅ 7 passing

✅ secret-scan

Status Policy Messages
✅ Passed secrets-detection -

✅ github-actions-scan

Status Policy Messages
✅ Passed ci-pipeline-security -

✅ sast-scan

Status Policy Messages
✅ Passed cwe-top25 -
✅ Passed owasp-top10-2025 -
✅ Passed sast -
✅ Passed cwe-top26-40-cusp -

✅ iac-scan

Status Policy Messages
✅ Passed iac-misconfiguration -
Scan not applied (1)
Scan Reason
vulnerability-scan no manifest/lockfile changed

View attestation ↗


Powered by Chainloop and Chainloop Trace

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/decisions_reconcile.yml">

<violation number="1" location=".github/workflows/decisions_reconcile.yml:345">
P2: This does not transition the existing reconcile PR from draft to ready: `create-pull-request` does not use `draft: false` as an update-time ready-for-review transition. Because this workflow reuses `decisions-reconcile-scheduled`, the first run after this change updates the old draft and reviewers still receive no notification; add a one-time `gh pr ready`/GraphQL transition (or migrate the existing PR) in addition to setting the create mode.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

automated
skip-ai-session
draft: true
draft: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This does not transition the existing reconcile PR from draft to ready: create-pull-request does not use draft: false as an update-time ready-for-review transition. Because this workflow reuses decisions-reconcile-scheduled, the first run after this change updates the old draft and reviewers still receive no notification; add a one-time gh pr ready/GraphQL transition (or migrate the existing PR) in addition to setting the create mode.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/decisions_reconcile.yml, line 345:

<comment>This does not transition the existing reconcile PR from draft to ready: `create-pull-request` does not use `draft: false` as an update-time ready-for-review transition. Because this workflow reuses `decisions-reconcile-scheduled`, the first run after this change updates the old draft and reviewers still receive no notification; add a one-time `gh pr ready`/GraphQL transition (or migrate the existing PR) in addition to setting the create mode.</comment>

<file context>
@@ -342,5 +342,5 @@ jobs:
             automated
             skip-ai-session
-          draft: true
+          draft: false
           delete-branch: true
</file context>

@migmartri
migmartri enabled auto-merge (squash) November 19, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants