No single quotes in media file insert url on mediaFileAdd!save.rol - #193
Merged
snoopdave merged 1 commit intoSep 27, 2026
Merged
Conversation
Member
|
this looks ok but we should probably filter through the code base and check all single quote usages to avoid having to update those one by one. |
Contributor
Author
|
I looked, could not find any more struts actions that adds html code. Thanks. |
Contributor
|
this one should go into 6.1.x branch too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uploaded confirmation page has a link "Create new weblog post" where it adds the image to a new weblog post, but uses single quotes and the image does not show correctly after saving/publishing (but should). Add media file from the New Entry page works, and uses double quotes.
Sorry, thought this was fixed by Matt's pr.