Conversation
…w entries The "create a post from your uploaded files" flow built its image and enclosure markup with single-quoted attributes and an invalid closing </img> tag, and the resulting image did not render after publishing. The media chooser on the entry editor already inserts the same link with double quotes and a self-closing img tag, and that form works, so this flow now matches it. Reported by Greg Huber on dev@roller.
mraible
force-pushed
the
fix-media-file-link-markup
branch
from
August 13, 2026 12:41
d737206 to
10d9cea
Compare
mbien
approved these changes
Sep 5, 2026
mbien
reviewed
Sep 5, 2026
| if (mediaFile.isImageFile()) { | ||
| link = "<p>" + mediaFile.getName() + "</p>"; | ||
| link += "<a href='<url>'><img src='<urlt>' alt='<name>' width='<width>' height='<height>'></img></a>"; | ||
| link += "<a href=\"<url>\"><img src=\"<urlt>\" alt=\"<name>\" width=\"<width>\" height=\"<height>\" /></a>"; |
Member
There was a problem hiding this comment.
so the fix is the missing / of this line and the quote change is to match other generated code? I see usage of both href=' and href=" but double quote is more common so thats good.
Contributor
Author
There was a problem hiding this comment.
Close. There are two changes on that line, and together they make the markup identical to what the entry editor's media chooser inserts, which is the path that renders correctly:
</img>becomes a self-closing/>, sinceimgis a void element and the closing tag is invalid. That's the/you spotted.- The attributes switch from single to double quotes, which also matches the other generated markup.
I changed both together to match the working path, so I can't say which of the two broke rendering on its own.
Contributor
|
I think this is superceded by #193. Please re-open if I am wrong about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "create a post from your uploaded files" flow builds its image and enclosure markup with single-quoted attributes and an invalid closing tag, and the resulting image does not render after publishing. The media chooser on the entry editor inserts the same link with double quotes and a self-closing img tag, and that form works, so this flow now matches it.
Reported by Greg Huber on dev@roller while testing the ROL-2183 branch; the bug exists on master independently of that work.