Skip to content

Use double-quoted attributes in media file links inserted into new entries #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mraible wants to merge 1 commit into from
Closed

Use double-quoted attributes in media file links inserted into new entries #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,14 @@ public String execute() {

if (mediaFile.isImageFile()) {
link = "<p>" + mediaFile.getName() + "</p>";
link += "<a href='<url>'><img src='<urlt>' alt='<name>' width='<width>' height='<height>'></img></a>";
link += "<a href=\"<url>\"><img src=\"<urlt>\" alt=\"<name>\" width=\"<width>\" height=\"<height>\" /></a>";

@mbien mbien Sep 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the fix is the missing / of this line and the quote change is to match other generated code? I see usage of both href=' and href=" but double quote is more common so thats good.

@mraible mraible Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close. There are two changes on that line, and together they make the markup identical to what the entry editor's media chooser inserts, which is the path that renders correctly:

  • </img> becomes a self-closing />, since img is a void element and the closing tag is invalid. That's the / you spotted.
  • The attributes switch from single to double quotes, which also matches the other generated markup.

I changed both together to match the working path, so I can't say which of the two broke rendering on its own.

link = link.replace("<url>", mediaFile.getPermalink())
.replace("<urlt>", mediaFile.getThumbnailURL())
.replace("<name>", mediaFile.getName())
.replace("<width>", ""+mediaFile.getThumbnailWidth())
.replace("<height>", ""+mediaFile.getThumbnailHeight());
} else {
link = "<a href='<url>'><name></a> (<size> bytes, <type>)";
link = "<a href=\"<url>\"><name></a> (<size> bytes, <type>)";
link = link.replace("<url>", mediaFile.getPermalink())
.replace("<name>", mediaFile.getName())
.replace("<size>",""+mediaFile.getLength())
Expand All @@ -97,7 +97,7 @@ public String execute() {
sb.append("<p>")
.append(getText("mediaFileEdit.includesEnclosure"))
.append("<br />")
.append("<a href='" + bean.getEnclosureURL() + "'>")
.append("<a href=\"" + bean.getEnclosureURL() + "\">")
.append(bean.getEnclosureURL())
.append("</a></p>");
}
Expand Down
Loading