Repository navigation
ci(cssholmes): verify and package alpha 1 - #9
Conversation
|
Sorry @mambax7, your pull request is larger than the review limit of 150,000 diff characters |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
| - 'v[0-9]+.[0-9]+.[0-9]+-[0-9A-Za-z]*' | ||
| - '[0-9]+.[0-9]+.[0-9]+-[0-9A-Za-z]*' |
| ]]); | ||
| $text = file_get_contents('http://' . $address . '/modules/cssholmes/' . $path, false, $context); | ||
| if ($text === false) { throw new RuntimeException('Endpoint request failed.'); } | ||
| $responseHeaders = http_get_last_response_headers(); |
There was a problem hiding this comment.
🔵 Needs a closer look
The release workflow does not trigger for the documented prerelease tag, and the specimen browser test uses a non-portable default path; the preload filename warning should also be corrected.
2 open issues
1 resolved since last review
Review effort: Lite
|
Sorry @mambax7, your pull request is larger than the review limit of 150,000 diff characters |
Summary
Final testing and packaging step for cssHolmes 3.3.0 Alpha 1. Contains 54 files: shared QA, browser and endpoint regressions, optional Qodana and prerelease archive automation. No module-local development vendor tree is added.
Release notes now follow the triggering tag (
docs/RELEASE-${GITHUB_REF_NAME#v}.md) and packaging stops if that file is missing. The release tag glob already supports dotted tags. The HTTP harness useshttp_get_last_response_headers(), available on the required PHP 8.4+ runtime.Merge readiness
Runtime/security PR #10 and documentation PR #11 are merged. This is the final testing and packaging PR, now targeting master. Optional browser tests use portable Playwright defaults with environment overrides, and the legacy preload test filename matches its class. Merge after CI passes on the latest commit.
Validation
The combined tree passed PHP 8.4.27 and 8.5.12: 35 PHPUnit tests / 115 assertions, 50 endpoint checks, storage/set/access/preview regressions, and follow-up checks for color tokens, image dimensions, history limits and manifest paths. Browser checks cover the designer, library, gallery, sessions, overlay labels and theme diagnostics. Scoped PHPStan reports no errors. Linux CI exercises symlink cases skipped by the local Windows account.
A disposable installed XOOPS 2.7.4-RC2 site also passed normal administrator login, real xStyles designer controls, save/reload, anonymous published CSS, permission and CSRF rejection, and restore. The gallery capability flag, configuration and integration scripts are supplied by cssHolmes's
eventCoreHeaderAddmetapreload; xStyles does not duplicate that initialization.PHP 8.4+ is required. Admin-theme publishing and native XOOPS 4 installation remain outside this alpha. No release tag or package has been published.