Repository navigation
fix(ci): pin slather to 2.8.5 - #254
Open
uc-brunosilva wants to merge 1 commit into
Open
uc-brunosilva wants to merge 1 commit into
uc-brunosilva wants to merge 1 commit into
Conversation
slather 2.8.6 (published 2026-10-09) fails on the iOS coverage step with "undefined method 'first' for nil" in profdata_coverage_dir, even though all 84 sampleTests pass. The last green run (2026-10-07) used 2.8.5. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Code Review by QodoSorry, something went wrongWe weren't able to complete the code review on our side. Please try again manually by commenting/agentic_review on this PR.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoPin Slather 2.8.5 to restore iOS coverage reporting
AI Description
High-Level Assessment
Files changed (1)
|
codeant-ai
Bot
added
the
size:XS
|
PR Summary: Pin Slather to 2.8.5 in CI to stabilize iOS coverage reporting.
|
CodeAnt PR Risk: Low Risk
Assessed commit: |
|
Reviewed up to commit:75bfc283e131176ad7166180f4a041e84fec53fb Looks good to me! 👍 Additional Suggestion.github/workflows/ci.yml, line:115-121Add a short verification step immediately after installing slather that fails early if the installed version is not the expected one, e.g. `slather --version | grep -q "2.8.5" || (slather --version; exit 1)`. This prevents silent future regressions if upstream versions change or install fails to pick the pinned version. - name: Install Slather
run: |
gem install slather -v 2.8.5 --no-document
slather --version | grep -q "2.8.5" || (echo "Unexpected slather version:"; slather --version; exit 1)Others- Good immediate fix: pinning slather to 2.8.5 addresses the CI break caused by slather 2.8.6 (released 2026-10-09). Make the pin explicit in source (Gemfile) and add a short comment in the workflow referencing the regression date and the failing stacktrace to make the rationale discoverable for future maintainers. Plan to unpin/update when slather releases a fixed version and verify the fix in CI before removing the pin. - name: Install Slather
run: |
# Pinning slather to 2.8.5 due to coverage regression in 2.8.6
# (NoMethodError: undefined method `first' for nil:NilClass in project.rb:237)
gem install slather -v 2.8.5 --no-document
- name: Generate iOS HTML Report
working-directory: ./sample/ios
run: |
slather coverage --html --output-directory html-report --scheme sample --workspace sample.xcworkspace sample.xcodeproj |
WORKFLOW-2 · Apps team PR OpenPolicies: "Pipeline misconfiguration added", "Pipeline misconfiguration removed"
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Problem
test-iosfails in the Generate iOS HTML Report step on every PR since 2026-10-09, while the tests themselves pass (84 tests, 0 failures,Test Succeeded):Cause
gem install slatheris unpinned. slather 2.8.6 was published on 2026-10-09; the last greentest-iosrun (2026-10-07,fix/MSDK-4862…) installed 2.8.5. Same workflow, same Xcode 16.1, same coverage flags, only the slather version differs.Fix
Pin
gem install slather -v 2.8.5. Found while validating the 2.33.0 bump in #253 (unrelated to the bump itself).🤖 Generated with Claude Code
CodeAnt-AI Description
Restore iOS coverage report generation in CI
What Changed
Impact
✅ iOS coverage reports generated after passing tests✅ Fewer CI failures during coverage reporting💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.