Repository navigation
fix(packaging): expand ${BINARY} in nfpm; bump to 0.1.0-rc.3 - #126
Merged
Merged
Conversation
nfpm does not expand environment variables in contents src unless the
entry sets expand: true, so the v0.1.0-rc.2 release build failed with
'glob failed: ${BINARY}: no matching files'. Verified with nfpm v2.41.1:
deb and rpm now build with /usr/bin/rtbit and both systemd units.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The v0.1.0-rc.2 release build failed at nfpm packaging; rc.3 carries the fix. Same set of files as the rc.2 bump, plus a CHANGELOG entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v0.1.0-rc.2release build failed atnfpm packagewithglob failed: ${BINARY}: no matching files: nfpm only expands environment variables in acontentssrcwhen the entry setsexpand: true. No GitHub release or download-host files were published for rc.2.d731dc3: addexpand: trueto the binary entry inpackaging/linux/nfpm.yaml. Reproduced and verified with the pinned nfpm v2.41.1: the deb and rpm both build, and the deb contains/usr/bin/rtbitplus the system and user units (version0.1.0~rc.2).5263340: bump everything to0.1.0-rc.3, the same files as chore(release): bump to 0.1.0-rc.2 #125, with a CHANGELOG entry for the fix. A pushed tag is never rewritten, so rc.2 stays as it is.Also dry-ran the release steps that come after packaging and had never run, against fake artefacts: the staging
installpaths all exist, andrender-aur.sh,render-homebrew.sh,render-flatpak.shandrender-winget.shall render with versions and hashes filled in. The cosign verification and the upload steps can only run in CI.Checks:
scripts/check-repo-hygiene.sh,scripts/test-publish.sh,cargo check -p rtbit.🤖 Generated with Claude Code