Skip to content

American to British: stop converting words with another meaning #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niksedk merged 1 commit into from
Nov 5, 2026
Merged

American to British: stop converting words with another meaning #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions se5/AmericanToBritish.Tests/BatchModeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,16 @@ public void Batch_ConvertsAllLines()
Assert.Null(response.SettingsVersion);
}

[Fact]
public void Batch_LeavesWordsWithAnotherMeaningAlone()
{
// pants/tire/draft/practice... are also verbs or nouns that British English spells the same (issue #16366)
var texts = new[] { "She pants heavily.", "I never tire of it.", "The first draft.", "Doctor's practice.", "A computer program.", "Install it.", "A parking meter.", "Licence or license." };
var response = BatchMode.BuildBatchResponse(Request(texts.Append("color").ToArray()), WordListPath);

Assert.Equal(texts.Append("colour"), Texts(response));
}

[Fact]
public void Batch_KeepsTimings()
{
Expand Down
28 changes: 14 additions & 14 deletions se5/Plugin-Shared/WordList.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,12 +262,12 @@
<Word us="donut" br="doughnut" />
<Word us="donuts" br="doughnuts" />
<Word us="draft beer" br="draught beer" />
<Word us="draft" br="draught" />
<Word us="draft" br="draught" only="BrToUs" />
<Word us="draftboard" br="draughtboard" />
<Word us="draftboards" br="draughtboards" />
<Word us="draftier" br="draughtier" />
<Word us="draftiest" br="draughtiest" />
<Word us="drafts" br="draughts" />
<Word us="drafts" br="draughts" only="BrToUs" />
<Word us="draftsman" br="draughtsman" />
<Word us="draftsmanship" br="draughtsmanship" />
<Word us="draftsmen" br="draughtsmen" />
Expand Down Expand Up @@ -506,10 +506,10 @@
<Word us="imperiling" br="imperilling" />
<Word us="initialed" br="initialled" />
<Word us="initialing" br="initialling" />
<Word us="install" br="instal" />
<Word us="install" br="instal" only="BrToUs" />
<Word us="installment" br="instalment" />
<Word us="installments" br="instalments" />
<Word us="installs" br="instals" />
<Word us="installs" br="instals" only="BrToUs" />
<Word us="instill" br="instil" />
<Word us="instills" br="instils" />
<Word us="jeweled" br="jewelled" />
Expand Down Expand Up @@ -545,7 +545,7 @@
<Word us="libeling" br="libelling" />
<Word us="libelous" br="libellous" />
<Word us="libelously" br="libellously" />
<Word us="license" br="licence" />
<Word us="license" br="licence" only="BrToUs" />
<Word us="liter" br="litre" />
<Word us="liters" br="litres" />
<Word us="louver" br="louvre" />
Expand Down Expand Up @@ -577,8 +577,8 @@
<Word us="meagerly" br="meagrely" />
<Word us="meagerness" br="meagreness" />
<Word us="mementos" br="mementoes" />
<Word us="meter" br="metre" />
<Word us="meters" br="metres" />
<Word us="meter" br="metre" only="BrToUs" />
<Word us="meters" br="metres" only="BrToUs" />
<Word us="micrometer" br="micrometre" />
<Word us="micrometers" br="micrometres" />
<Word us="milliliter" br="millilitre" />
Expand Down Expand Up @@ -686,7 +686,7 @@
<Word us="paneling" br="panelling" />
<Word us="panelist" br="panellist" />
<Word us="panelists" br="panellists" />
<Word us="pants" br="trousers" />
<Word us="pants" br="trousers" only="BrToUs" />
<Word us="paralleled" br="parallelled" />
<Word us="paralyze" br="paralyse" />
<Word us="paralyzed" br="paralysed" />
Expand Down Expand Up @@ -745,16 +745,16 @@
<Word us="popularizers" br="popularisers" />
<Word us="popularizes" br="popularises" />
<Word us="popularizing" br="popularising" />
<Word us="practice" br="practise" />
<Word us="practice" br="practise" only="BrToUs" />
<Word us="practiced" br="practised" />
<Word us="practicer" br="practiser" />
<Word us="practicers" br="practisers" />
<Word us="practices" br="practises" />
<Word us="practices" br="practises" only="BrToUs" />
<Word us="practicing" br="practising" />
<Word us="pretense" br="pretence" />
<Word us="pretenses" br="pretences" />
<Word us="program" br="programme" />
<Word us="programs" br="programmes" />
<Word us="program" br="programme" only="BrToUs" />
<Word us="programs" br="programmes" only="BrToUs" />
<Word us="prolog" br="prologue" />
<Word us="prologs" br="prologues" />
<Word us="psychoanalyze" br="psychoanalyse" />
Expand Down Expand Up @@ -934,8 +934,8 @@
<Word us="theatergoers" br="theatregoers" />
<Word us="theaterland" br="theatreland" />
<Word us="theaters" br="theatres" />
<Word us="tire" br="tyre" />
<Word us="tires" br="tyres" />
<Word us="tire" br="tyre" only="BrToUs" />
<Word us="tires" br="tyres" only="BrToUs" />
<Word us="toweled" br="towelled" />
<Word us="toweling" br="towelling" />
<Word us="towelings" br="towellings" />
Expand Down
Loading