Repository navigation
American to British: stop converting words with another meaning - #342
Merged
Merged
Conversation
pants (verb), tire (verb), draft (document), practice/license (British
nouns), program (computer), meter (device) and install are standard
British English in those senses, so US->BR replaced correct text
("She pants" -> "She trousers"). They now only apply British to American.
SubtitleEdit/subtitleedit#16366
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SubtitleEdit/subtitleedit#16366 for the SE5 plugin. The SE4 list already had `pants` commented out (0509bd1); the shared SE5 list did not.
These pairs are now `only="BrToUs"`. British to American still converts them, and that direction is correct:
Unambiguous forms such as practiced, practising, draughty and draughtsman still convert.
Adds a regression test.
🤖 Generated with Claude Code