Separate reader panels and controls from session coordination - #4
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reader toolbar/progress controls, contents and settings were embedded in an 1,861-line session widget. Extract them into focused presentation modules, keeping session ownership, viewport coordination and keyboard handling in the shell. The package public exports and builder contexts remain compatible.
Consolidate the completed task plan's lasting library decisions into the existing architecture reference; retain its detailed worker, layout, PDF and theme contracts. Remove the task plan and unused pubspec template comments.
Validation: 144 reader unit/widget tests, two example tests, library/example analysis, formatting, generated worker drift check and example web build passed. Chromium smoke checks passed for PDF pagination/continuous scroll, column/appearance refitting, opposite-theme menus, chapter keyboard navigation, focus mode, responsive layouts, local files and worker cleanup.
Linux, Windows and macOS build validation is handled by the existing PR CI. The client cleanup PR will pin this immutable reader commit.