Repository navigation
Remove retired client UI and split acquisition and filter components - #30
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Repository housekeeping.
Summary
Remove 21 unreachable Dart implementations, five tests for retired implementations, four unused image assets, two unused direct dependencies, and two server workflows incorrectly copied into the client repository. Preserve useful retry, cleanup and account-scope coverage against the active BookImportController/BookImportSheet flow.
Extract the acquisition gateway and shared library filter fields into focused modules, retaining existing gateway imports. Pin the published reader cleanup commit
c870bf4df98b01530c6b6e6ae5cd59bd5ea58cc3from reader #4.Remove four completed task-plan documents, correct format/storage claims and retire obsolete verification logs and build-artifact links in docs. Explicitly ignore local reader dependency overrides.
Testing
Full Flutter suite: 1,315 passed, 19 skipped (including existing opt-in network tests). Formatting and analysis passed; four web-bootstrap tests and the release web build passed. Dependency installation succeeds with
--enforce-lockfile. Added regressions cover partial retry without duplicate imports, cleanup retry/concurrency, duplicate commit protection, picker cancellation and route-back cleanup while parsing finishes.The Cupertino icon dependency is retained because the release build exposes an indirect use of its font. Native file parsers and persisted compatibility types remain active and are retained.
UI evidence
UI extraction preserves existing behavior; widget tests exercise the active import route and current filter controls. Reader visual/browser validation is recorded in reader #4.
Compatibility and migration
No data migrations or HTTP contract changes. Account/profile isolation, media rollback and stored reader locators retain their existing coverage. Merge reader #4 before this PR.
Notes
Removal candidates were traced through the runtime import graph and checked for conditional imports, platform references and active callers. Guest sample data is still used by the book-details provider and is retained.
Checklist