Repository navigation
DOMNode declares refresh_lines beside refresh - #247
Merged
Merged
Conversation
Widget.refresh_lines (#246) had no DOMNode default, so a walk over the DOM (Toad's ConversationEntry repaints its subtree) could not call it without a cast; refresh already has the node-level answer that a node painting nothing returns itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+4 lines. #246's
Widget.refresh_lineshad noDOMNodedefault, so a walk over the DOM can't call it without a cast. Toad'sConversationEntry.repaintwalks its subtree, and toad#1558's NRA gate flagged"DOMNode" has no attribute "refresh_lines".refreshalready has that node-level answer, a node that paints nothing returns itself, sorefresh_linesgets the same.🤖 Generated with Claude Code