Repository navigation
Repainting every line is repaint_lines; refresh_lines keeps its one meaning - #248
Merged
Merged
Conversation
…eaning #246 and #247 declared refresh_lines() on Widget and DOMNode to mean "repaint every line", but ScrollView already declares refresh_lines(y_start, line_count=1), the range refresh Log and TextArea call. A no-argument call on a ScrollView raised TypeError, and Toad's block navigation calls it on every child, so every fade repaint of a scrolling block failed on the installed Toad. The new meaning takes its own name. Nothing in Textual's src, tests or docs calls the no-argument form; TextArea's four calls pass a line and keep ScrollView's meaning. Found and proven by claude-b-ui (Toad's six failing test files: 10 passed with this plus Toad's three caller renames). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix, 2 lines in 2 files. The installed Toad raises
TypeError: ScrollView.refresh_lines() missing 1 required positional argument: 'y_start'on every fade repaint of a scrolling block.Before: #246/#247 declared
refresh_lines()onDOMNode(dom.py:2293) andWidget(widget.py:4248) to mean "repaint every line".ScrollViewalready declaresrefresh_lines(y_start, line_count=1)(scroll_view.py:182), the range refreshLog(_log.py:354) andTextAreacall. One name, two facts: a no-argument call that lands on a ScrollView raises. Toad's block_navigation.py:363 calls it on every child.After: the repaint-everything meaning is
repaint_lines().refresh_lineskeeps its one meaning, the range refresh.Callers:
git grep -n "refresh_lines()"over src, tests and docs finds none of the no-argument form. TextArea's four calls (_text_area.py:821, 1651, 1954, 1959) pass a line and keep ScrollView's meaning. Toad's three callers (block_navigation.py:363, frame_presentation.py:351, switch_toast.py:199) move torepaint_lines()in the Toad PR claude-b-ui opens on this merge commit, with the relock.Proof: claude-b-ui ran Toad's six test files that died on the TypeError against this commit plus the three Toad renames, with toad#1557's fail-fast: 10 passed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd