Repository navigation
fix(point): continue encoding after skipping oversized points - #213
Merged
Merged
Conversation
coanor
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A point can fit the initial size check but exceed the buffer after Protobuf framing. Trimming that point previously returned end-of-iteration and silently discarded the remaining input. For example, one oversized point followed by 200 normal points produced zero output while reporting only one skipped point.
Continue encoding after a skipped point using an in-function retry, and accept payloads that exactly fill the buffer. Truly oversized points remain skipped without affecting subsequent points. Update the existing exhaustion assertion and add regression coverage for exact-fit payloads, oversized points at each position, 4,096 consecutive oversized points, nil input, output ordering, and error propagation in both size modes.
Validation:
-raceafter it.TestV2Encode,TestEncTrim, andTestSkipLargePointtests pass with-race.git diff --checkpass.make testencountered unrelated diskcache/tmpexhaustion and an HTTP rate-limit assertion failure. The existing million-iterationTestPoolKVResuablewas stopped after more than five minutes; the full point suite is not claimed as passed.Tested on Linux/arm64 with CGO enabled and vendor dependencies.