Repository navigation
fix(point): preserve progress when trimming protobuf batches - #215
Merged
Merged
Conversation
coanor
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protobuf size estimation can admit a batch that exponential trimming removes completely, rewinding the input index and making the retry loop from #213 run forever. Trimming can also exceed the remaining slice length and panic.
Cap each trim at the number of remaining points minus one, and update the input index and counters by the actual number removed. This leaves one candidate for the existing encode-or-skip decision, guaranteeing progress without changing strict-error or oversized-point handling.
Regression coverage includes a 1 MiB batch of three individually encodable points, precise-size protobuf envelope overhead, exact/excessive trimming, and an oversized point followed by tiny points. Both ignore and strict modes check decoded bytes, ordering, counters and callbacks. A direct progress check fails before calling Next if the original infinite-loop regression returns.
Validation on Linux arm64, Go 1.26.10, CGO enabled: