Skip to content

tests: read the write guards from _post (main red after #977 + #978) #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eaitbrahim merged 1 commit into from
Oct 12, 2026
Merged

tests: read the write guards from _post (main red after #977 + #978) #984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/web/test_web_prose_stays_true.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,10 @@ def _refusing_guards(method: object, *, stop_at: str | None = None) -> list[ast.
def test_the_phrase_check_names_its_place_among_every_check_before_it() -> None:
"""`run_gated_action` is the LAST check a release passes. Its docstring says how many come
first and which; both are read here from the two handler methods that run them, so a check
added to `do_POST` (as `Sec-Fetch-Site` was) fails this until the docstring counts it."""
added to `do_POST` (as `Sec-Fetch-Site` was) fails this until the docstring counts it.
`do_POST` itself only wraps `_post` in the body drain (#955), so the guards are read there."""
handler = server.KeelHandler
before_dispatch = _refusing_guards(handler.do_POST, stop_at="_gated_action")
before_dispatch = _refusing_guards(handler._post, stop_at="_gated_action")
in_gated_action = _refusing_guards(handler._gated_action)
checks = len(before_dispatch) + len(in_gated_action) + 1 # + the phrase itself

Expand Down
Loading