Repository navigation
tests: read the write guards from _post (main red after #977 + #978) - #984
Merged
Merged
Conversation
#978's prose test counted do_POST's refusing guards; #977 made do_POST a drain wrapper around _post, so the walk never reached _gated_action and main went red. The count is unchanged (four + two + the phrase = seven), so only the test moves. Mutation-checked: dropping the Sec-Fetch-Site guard from _post fails it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red after #977 and #978 merged together:tests/web/test_web_prose_stays_true.py::test_the_phrase_check_names_its_place_among_every_check_before_itfails with'_gated_action' was never reached.Why: #978's test walks
do_POST's refusing guards up to the_gated_actiondispatch. #977 (#955) turneddo_POSTinto a wrapper that runs_postand then drains the body in afinally, so the guards and the dispatch now live in_post.Fix: the test reads
_post. The stated count is still right: four guards in_post, plus two in_gated_action, plus the phrase, makes seven. Sogates.py's "seven checks" sentences stay as they are.Verified
Sec-Fetch-Siteguard from_postmakes the test fail.🤖 Generated with Claude Code