Skip to content

Worktree social layer - #6

Merged
zacktiger merged 2 commits into
mainfrom
worktree-social-layer
Aug 4, 2026
Merged

zacktiger merged 2 commits into
mainfrom
worktree-social-layer

Conversation

@zacktiger

@zacktiger zacktiger commented Aug 4, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Documentation

    • Reorganized and condensed the README with updated setup guidance, rollout status, privacy details, and local-only storage limitations.
    • Added an overview of note follow-ups, resurfacing, hashtags, feed publishing, accounts, privacy, and unsupported integrations.
  • Bug Fixes

    • Improved feed card navigation by separating author profile and post content interactions.
    • Enhanced accessibility labels for distinct feed card actions.

zacktiger and others added 2 commits August 5, 2026 00:47
Running the app turned up a nested button: the avatar's link to the
profile and the like control both sat inside the card's own Pressable.
Native tolerates that, the web surface renders invalid DOM, and a screen
reader announces the whole row as one control with mystery children
everywhere.

Now the byline, the body and the like are siblings: tap the name for the
author, the title for the thread, the heart to like. Console is clean.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017DRL4dVgg5oebLSTenQv2G
The intro had grown into a sales page: three sections explaining the loop,
the sharing and the positioning before anyone reached a command. All of
that moves to docs/about.md, which is where somebody who wants the
argument can go and find it.

What stays is what a README is for -- what this is in four lines, where it
has got to, how to run it, and where things live. 99 lines, down from 200
and shorter than before the social layer landed.

docs/about.md is the friendly read; product.md stays the authoritative one
and says so at the top of it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017DRL4dVgg5oebLSTenQv2G
@coderabbitai

coderabbitai Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

FeedCard now separates author and post navigation. The README is condensed and reorganized. A new about page documents DailyNote’s workflow, publishing, accounts, and privacy model.

Changes

Feed navigation

Layer / File(s) Summary
Separate FeedCard navigation controls
apps/mobile/src/components/feed-card.tsx
The author row navigates to profiles. The title and preview navigate to posts. Accessibility labels identify each target separately. Like and statistics controls remain independent.

Product documentation

Layer / File(s) Summary
Product and privacy documentation
README.md, docs/about.md
The README now contains condensed product, rollout, setup, credential, database, and layout information. The new about page documents follow-up behavior, Feed publishing, accounts, privacy, encryption limits, and unsupported integrations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

A rabbit taps the author name,
Then hops to posts without a tangle.
The README sheds its extra leaves,
About pages bloom with clearer themes.
Privacy rests beneath the moon.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too broad and does not clearly identify the FeedCard navigation and documentation changes. Use a specific title such as "Split FeedCard navigation targets and update product documentation".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch worktree-social-layer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zacktiger
zacktiger merged commit 973e6c5 into main Aug 4, 2026
1 of 2 checks passed
@zacktiger
zacktiger deleted the worktree-social-layer branch August 4, 2026 19:35

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Around line 14-15: Replace “afterwards” with “afterward” in README.md lines
14-15 and docs/about.md lines 42-45, preserving the surrounding text.
- Around line 32-33: Use a single rollout status for the four-answer workflow:
in README.md lines 32-33, either mark the four-answer card as shipped or retain
it as planned; in docs/about.md lines 18-29, apply the same status and update
the review ladder label to match.
- Around line 73-79: Update the fenced code block containing the repository
package listing in README.md to specify the text language on its opening fence,
preserving the existing block contents.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6c6de2bc-c344-42a5-8752-2c725629b678

📥 Commits

Reviewing files that changed from the base of the PR and between 49896a4 and 557e407.

📒 Files selected for processing (3)
  • README.md
  • apps/mobile/src/components/feed-card.tsx
  • docs/about.md

Comment thread README.md
Comment on lines +14 to +15
The ones worth showing people, you can publish to a **Feed** — note by note, afterwards, and only
if you want to. Nothing is public unless you say so, and writing needs no account at all.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use afterward in both documents.

  • README.md#L14-L15: replace afterwards with afterward.
  • docs/about.md#L42-L45: replace afterwards with afterward.
🧰 Tools
🪛 LanguageTool

[locale-violation] ~14-~14: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ...n publish to a Feed — note by note, afterwards, and only if you want to. Nothing is pu...

(AFTERWARDS_US)


[style] ~14-~14: This phrasing can be overused. Try elevating your writing with a more formal alternative.
Context: ...** — note by note, afterwards, and only if you want to. Nothing is public unless you say so, a...

(IF_YOU_WANT)

📍 Affects 2 files
  • README.md#L14-L15 (this comment)
  • docs/about.md#L42-L45
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 14 - 15, Replace “afterwards” with “afterward” in
README.md lines 14-15 and docs/about.md lines 42-45, preserving the surrounding
text.

Source: Linters/SAST tools

Comment thread README.md
Comment on lines +32 to +33
| 🚧 | Follow-through (notes come back; the four-answer card is next) · accounts (sync is next) |
| — | Share sheet and URL scheme · import · ship |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use one rollout status for the four-answer workflow.

  • README.md#L32-L33: mark the four-answer card as shipped, or keep it as planned.
  • docs/about.md#L18-L29: match the selected status and label the review ladder accordingly.
📍 Affects 2 files
  • README.md#L32-L33 (this comment)
  • docs/about.md#L18-L29
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 32 - 33, Use a single rollout status for the
four-answer workflow: in README.md lines 32-33, either mark the four-answer card
as shipped or retain it as planned; in docs/about.md lines 18-29, apply the same
status and update the review ladder label to match.

Comment thread README.md
Comment on lines +73 to +79
```
apps/mobile Expo app (expo-router, NativeWind) MIT
packages/core pure TS domain logic, no RN, no Supabase MIT
packages/db Drizzle schema + Postgres migrations AGPL-3.0
supabase migrations, RLS policies AGPL-3.0
docs about.md, product.md, the plans, auth.md, ADRs
```

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add a language to the layout code fence.

Line 73 opens a fenced block without a language. Use text so markdownlint passes MD040.

Proposed fix
-```
+```text
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
```
apps/mobile Expo app (expo-router, NativeWind) MIT
packages/core pure TS domain logic, no RN, no Supabase MIT
packages/db Drizzle schema + Postgres migrations AGPL-3.0
supabase migrations, RLS policies AGPL-3.0
docs about.md, product.md, the plans, auth.md, ADRs
```
🧰 Tools
🪛 markdownlint-cli2 (0.23.2)

[warning] 73-73: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 73 - 79, Update the fenced code block containing the
repository package listing in README.md to specify the text language on its
opening fence, preserving the existing block contents.

Source: Linters/SAST tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant