Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/web/.env.example
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ NVIDIA_API_KEY=
# Shared secret used when creating repo webhooks + verifying deliveries
# Must match production Vercel env AND the secret on each GitHub webhook.
GITHUB_WEBHOOK_SECRET=
# ─── Nova Agent Browser (Browserbase) ───
# Required in the web server environment to enable Nova's shared browser.
NOVA_AGENT_BROWSER_BROWSERBASE_API_KEY=
NOVA_AGENT_BROWSER_BROWSERBASE_PROJECT_ID=
# ─── AI Gateway (PR reviews + embeddings) ───
# PR reviews prefer Merge when MERGE_GATEWAY_API_KEY is configured, then direct
# OPENAI/ANTHROPIC/GOOGLE keys. Without a Merge key, the shared gateway order applies.
Expand Down
2 changes: 1 addition & 1 deletion apps/web/modules/nova-web/components/browser-pane.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export function BrowserPane({ sessionId }: { sessionId: string }) {
<div className="mb-5 flex size-14 items-center justify-center rounded-xl border border-white/[0.08] bg-white/[0.025]"><Globe className="size-6 text-[#999]" strokeWidth={1.25} /></div>
<h2 className="text-sm font-medium text-[#ddd]">{pending ? "Connecting…" : active ? browser.control === "agent" ? "Nova’s browser workspace" : "Browser is connecting" : "Browse together"}</h2>
<p className="mt-2 max-w-64 text-xs leading-5 text-[#999]">
{!state ? error ? "Use reconnect to retry the browser service." : "Checking browser configuration…" : !state.configured ? "Configure BROWSERBASE_API_KEY and BROWSERBASE_PROJECT_ID on the server to enable the shared browser." : active ? browser.control === "agent" ? "Nova can inspect and navigate this session. Take control to interact, sign in, or complete sensitive actions." : disconnected ? "The live view disconnected. Reconnect or stop this session." : "Waiting for a safe connection. Use reconnect to refresh the view." : "Open an isolated cloud browser, then hand it to Nova when you’re ready. Sessions run for up to 15 minutes."}
{!state ? error ? "Use reconnect to retry the browser service." : "Checking browser configuration…" : !state.configured ? "Configure NOVA_AGENT_BROWSER_BROWSERBASE_API_KEY and NOVA_AGENT_BROWSER_BROWSERBASE_PROJECT_ID on the server to enable the shared browser." : active ? browser.control === "agent" ? "Nova can inspect and navigate this session. Take control to interact, sign in, or complete sensitive actions." : disconnected ? "The live view disconnected. Reconnect or stop this session." : "Waiting for a safe connection. Use reconnect to refresh the view." : "Open an isolated cloud browser, then hand it to Nova when you’re ready. Sessions run for up to 15 minutes."}
</p>
{!active && state?.configured ? <button type="button" disabled={pending} onClick={() => void request("POST")} className={`${buttonClass} mt-5 bg-white/[0.06]`}>{pending ? <Loader2 className="size-3 animate-spin" /> : <Play className="size-3" />}Start browser</button> : null}
{pending || (!state && !error) ? <Loader2 className="mt-4 size-4 animate-spin text-[#777]" /> : null}
Expand Down
15 changes: 14 additions & 1 deletion apps/web/modules/nova/browser/provider.test.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,21 @@
import { describe, expect, test } from "bun:test"

import { createBrowserbaseProvider, validateProviderUrl } from "./provider"
import { browserConfigured, browserbaseConfig, createBrowserbaseProvider, validateProviderUrl } from "./provider"
import { BrowserCreationRejectedError } from "./contracts"

test("Browserbase config reads the Nova-prefixed production environment names", () => {
expect(browserbaseConfig({})).toEqual({ apiKey: "", projectId: "" })
expect(browserConfigured({})).toBe(false)
const config = browserbaseConfig({
NOVA_AGENT_BROWSER_BROWSERBASE_API_KEY: " key ",
NOVA_AGENT_BROWSER_BROWSERBASE_PROJECT_ID: " project ",
})
expect(config).toEqual({ apiKey: "key", projectId: "project" })
expect(browserConfigured({ NOVA_AGENT_BROWSER_BROWSERBASE_API_KEY: "key", NOVA_AGENT_BROWSER_BROWSERBASE_PROJECT_ID: "project" })).toBe(true)
expect(browserConfigured({ NOVA_AGENT_BROWSER_BROWSERBASE_API_KEY: " ", NOVA_AGENT_BROWSER_BROWSERBASE_PROJECT_ID: "project" })).toBe(false)
expect(browserbaseConfig({ NOVA_AGENT_BROWSER_BROWSERBASE_API_KEY: "", NOVA_AGENT_BROWSER_BROWSERBASE_PROJECT_ID: "project" })).toEqual({ apiKey: "", projectId: "project" })
})

describe("Browserbase creation failures", () => {
for (const [status, detail, expected] of [
[401, "secret response", "rejected the API key"],
Expand Down
16 changes: 13 additions & 3 deletions apps/web/modules/nova/browser/provider.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
import { BrowserCreationRejectedError, BrowserError, LIVE_VIEW_TTL_SECONDS, type BrowserProvider } from "./contracts"
import { browserLiveViewUrl } from "@/modules/nova-web/browser-view"

export function browserConfigured(): boolean {
return Boolean(process.env.BROWSERBASE_API_KEY?.trim() && process.env.BROWSERBASE_PROJECT_ID?.trim())
type BrowserbaseEnvironment = Record<string, string | undefined>

export function browserbaseConfig(env: BrowserbaseEnvironment = process.env) {
return {
apiKey: env.NOVA_AGENT_BROWSER_BROWSERBASE_API_KEY?.trim() ?? "",
projectId: env.NOVA_AGENT_BROWSER_BROWSERBASE_PROJECT_ID?.trim() ?? "",
}
}

export function browserConfigured(env: BrowserbaseEnvironment = process.env): boolean {
const config = browserbaseConfig(env)
return Boolean(config.apiKey && config.projectId)
}

export function validateProviderUrl(value: unknown, kind: "live" | "cdp"): string {
Expand Down Expand Up @@ -39,7 +49,7 @@ export function createBrowserbaseProvider(
let message = "Browserbase request failed; retry later"
let status = 502
if (response.status === 401) {
message = "Browserbase rejected the API key; check the deployed BROWSERBASE_API_KEY"
message = "Browserbase rejected the API key; check the deployed NOVA_AGENT_BROWSER_BROWSERBASE_API_KEY"
status = 503
} else if ((response.status === 400 || response.status === 403 || response.status === 402) && /keep.?alive/.test(detail)) {
message = "Browserbase requires a paid plan with keep-alive support for Nova's shared browser"
Expand Down
7 changes: 2 additions & 5 deletions apps/web/modules/nova/browser/server.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
import { createBrowserService } from "./lifecycle"
import { browserConfigured, createBrowserbaseProvider } from "./provider"
import { browserbaseConfig, browserConfigured, createBrowserbaseProvider } from "./provider"
import { browserStore } from "./store"

export function browserService() {
return createBrowserService({
store: browserStore,
configured: browserConfigured(),
provider: createBrowserbaseProvider({
apiKey: process.env.BROWSERBASE_API_KEY ?? "",
projectId: process.env.BROWSERBASE_PROJECT_ID ?? "",
}),
provider: createBrowserbaseProvider(browserbaseConfig()),
})
}
4 changes: 2 additions & 2 deletions apps/web/modules/nova/sessions/turn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { authorizeHarnessRun, durableStore, harnessCheckpoint } from "../harness

import { browserService } from "@/modules/nova/browser/server"
import { browserHarnessTools, executeBrowserTool, isBrowserTool } from "@/modules/nova/browser/tools"
import { createBrowserbaseProvider } from "@/modules/nova/browser/provider"
import { browserbaseConfig, createBrowserbaseProvider } from "@/modules/nova/browser/provider"

import { CHATGPT_PROVIDER, CHATGPT_UNAVAILABLE_MESSAGE } from "@/modules/nova/chatgpt/contracts"
import { CODEX_PROVIDER } from "@/modules/nova/codex/models"
Expand Down Expand Up @@ -766,7 +766,7 @@ export async function* runWebTurn(input: {
if (isBrowserTool(toolName)) {
if (!browserClaim || mode !== "agent") return { successful: false, error: "Browser agent control is not enabled" }
const { runCdpAction } = await import("@/modules/nova/browser/cdp")
const provider = createBrowserbaseProvider({ apiKey: process.env.BROWSERBASE_API_KEY ?? "", projectId: process.env.BROWSERBASE_PROJECT_ID ?? "" })
const provider = createBrowserbaseProvider(browserbaseConfig())
return executeBrowserTool({ name: toolName, args, scope: browserScope, expected: browserClaim, service: browser, connection: provider.connection, run: runCdpAction, signal })
}
if (workspace) return workspace.execute(toolName, args)
Expand Down
Loading