Repository navigation
fix(nova): avoid deserializing advisory lock void results - #361
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Caution Review failedThe pull request is closed. WalkthroughThe sandbox reservation transaction now executes its organization-scoped advisory lock with ChangesSandbox reservation
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk:
|
Fix Nova cloud workspace startup failing with
Failed to deserialize column of type 'void'.Use
$executeRawforpg_advisory_xact_lockinstead of$queryRaw. The same parameterized, transaction-scoped organization lock still runs before the concurrency check, without asking Prisma to deserialize PostgreSQL'svoidreturn value.Add a regression test that rejects result-reading queries and verifies the lock SQL, bound organization key, and lock-before-quota ordering. Update the pinned-checkout mock to use the execution-only method.
Verified: 11 focused tests, web TypeScript, scoped ESLint, and
git diff --checkpassed. No migration required. Production database execution was not exercised.Summary by CodeRabbit