Repository navigation
fix(release): map authentication event error types to user_management - #267
Merged
Merged
Conversation
…agement The strict changelog scope gate on PR #266 failed because the first compat change to the inline `data.error` objects on the `authentication.*_failed` / `authentication.sso_timed_out` event payloads (adding `radar_detection_id`) surfaced emitter-synthesized names such as `AuthenticationEmailVerificationFailedDataError`. Those names never appear in the spec, so no IR service owns them and only scopeFromName can place them. The existing `^Authenticate` rule does not match the `Authentication…` spelling and the MFA / SSO / MagicAuth rules are anchored, so every symbol fell to the `sdk` fallback and the check went red. Add an `^Authentication` rule after the anchored MFA rule so `AuthenticationFactor` / `AuthenticationChallenge` keep multi_factor_auth and `AuthenticationRadar*` keeps radar. With the PR's exact inputs the entry now resolves to "Add `radar_detection_id` to user management models" and --strict-scopes passes.
Contributor
 [Medium impact] The PR appears safe to merge. SummaryMaps generated authentication event error types to
Reviews (1) · Last reviewed commit: "fix(release): map inline authentication ..." · Reviewed by Greptile |
gjtorikian
deleted the
fix/changelog-scope-authentication-event-errors
branch
November 6, 2026 18:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
radar_detection_idto the inlinedata.errorobjects on theauthentication.*_failedandauthentication.sso_timed_outevent payloads, and the resulting compat entry resolved to thesdkfallback scope, which has no docs URL.AuthenticationEmailVerificationFailedDataError,AuthenticationMfaFailedDataError,AuthenticationSSOTimedOutDataError, and so on). The names never appear in the spec, no IR service owns them, and onlyscopeFromNamecan place them.^Authenticatedoes not cover theAuthentication…spelling, and the MFA, SSO, and MagicAuth rules are anchored to the start of the name.^Authenticationrule that resolves touser_management, placed after the anchored MFA rule soAuthenticationFactorandAuthenticationChallengekeepmulti_factor_auth, and after theRadarrule soAuthenticationRadarRiskDetectedDatakeepsradar. Mirrors the existing waitlist and resource-export handling for event-payload-only types.radar_detection_idto user management models".Unblocks #266.