Conversation
…ons stand-in The public cache service only accepts uploads with a GitHub Actions OIDC token for a push to the registered repository's main branch, whose audience is the endpoint. The test backend accepted any upload, so the e2e cases never sent a token and never exercised the client's OIDC support. The backend process now stands in for GitHub's token service, and `remote-cache-server run --github-actions` runs a command as if in a GitHub Actions job with `id-token: write`. The request token picks the workflow run that the token is for, a push to `main` by default. Like the service, the backend checks the token's signature, time bounds, audience, and claims, and answers other stores with `401 Invalid credentials` or `403 Write not permitted`. Every step that uploads now runs with `--github-actions`. The only snapshot changes are those command lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fspy benchmarklinuxmacoswindows |
wan9chi
added this pull request to stack #812
October 5, 2026 05:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The public cache service from #718 only accepts uploads with a GitHub Actions OIDC token. The token has to come from a push to the registered repository's main branch, and its audience has to be the endpoint. The file backend accepted any upload, so the e2e cases never sent a token and never exercised the client's OIDC support from #798.
Changes
remote-cache-server run --github-actionsruns a command as if in a job withid-token: write: it setsACTIONS_ID_TOKEN_REQUEST_URL, andACTIONS_ID_TOKEN_REQUEST_TOKENdefaults tomain-push. The request token picks the workflow run the token is for:main-pushorpull-request.401 Invalid credentialsor403 Write not permitted.--github-actions. The only snapshot changes are those command lines.Stacked on #808.
🤖 Generated with Claude Code