Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
sql-pipeand its embedded Parquet implementation from Zig 0.16 to Zig 0.17.0.Zig 0.17 compatibility changes
**) to@splator explicit repeated test buffersAllocator.dupeZwithdupeSentinelstd.hash.crc.Crc32paths withstd.hash.Crc32builtin.os.tagchecks tobuiltin.target.os.tagb.argstoaddPassthruArgs()@cImportpath with a build-systemaddTranslateCmoduleParquet coverage
The normal sql-pipe build does not semantically analyze every vendored Parquet path because of Zig's lazy analysis. This migration found two additional stale CRC API uses in
parquet_reader.zigandcolumn_writer.zig.A fixture-independent
zig build checkstep was added to the embedded Parquet build and is now exercised by top-level CI with pure-Zig codecs.Validation
Green on Zig 0.17.0:
x86_64-linux-muslx86_64-windows-gnuaarch64-macosThe temporary cross-build workflow used for validation was removed after it passed, so it adds no permanent CI cost.
No dependency upgrades or unrelated feature changes.
Closes #254