Repository navigation
🐛 Preserve file capture identity during SHA preflight - #378
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Robdel12
changed the title
This comment has been minimized.
This comment has been minimized.
Robdel12
marked this pull request as ready for review
October 26, 2026 04:48
Keep preflight capture names identical to multipart filenames so retries and SHA reuse retain the same screenshot identity. Verify the names through the real upload command and HTTP boundary.
Keep the historical preflight name and send the complete filename as an optional field. This lets older APIs ignore the addition while updated APIs match preflight captures to multipart uploads and approved baselines. Verify public SDK behavior against byte-only APIs and APIs that ignore the additive filename field, alongside the real upload-command request flow.
Keep HTTP fallback coverage with the endpoint tests and public file-uploader compatibility with the SDK tests. Remove the separate suite and its simulated backend deduplication test; real API workflows already verify image ownership.
Robdel12
force-pushed
the
rd/project-image-names
branch
from
October 26, 2026 04:51
697e9db to
dc694bd
Compare
Robdel12
enabled auto-merge (squash)
October 26, 2026 04:51
This comment has been minimized.
This comment has been minimized.
Vizzly - Visual Test ResultsCLI Reporter - Waiting for buildNo builds received yet for this pull request. CLI TUI - 4 changes need review
Meaningful diffs needing review (4)vizzly-help · 1202×1430 · 0.0% diff vizzly-tdd-help · 1202×578 · 0.1% diff vizzly-doctor · 1202×578 · 0.2% diff vizzly-invalid-command · 1202×578 · 0.1% diff
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File preflight removes
.pngfromname, while multipart keeps the full filename. A SHA-capable API needs both requests to describe the same capture so upload fallback and retries preserve its identity and baseline match.Keep the released
namefield and add an optionalfilenamethrough the shared CLI and SDK file uploader. Older APIs can ignore the new field and receive the same names as before. Literal screenshot names and the SDK's byte-upload fallback stay unchanged.All 277 uploader, upload-command, API transport and SDK tests pass. The real CLI command verifies the additive payload, and public SDK HTTP tests cover an older API that ignores
filename, a byte-only API, and preservation of literal names such asCheckoutandCheckout.pngduring upload fallback.An unchanged v0.38.0 CLI also completed two builds against the local API and real comparison workers, retaining four captures while writing the original image once.