Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The ignored TCP_NODELAY result lacks the Rust-guideline-required explanation of why failure is safe to ignore.
1 open issue
What changed in this PR
This PR enables TCP_NODELAY on accepted registry connections to reduce delayed-ACK latency when clients repeatedly read small objects.
Changes:
- Set
TCP_NODELAYin the registry’s connection acceptance loop. - Add a regression test checking median latency for repeated small DAV reads.
- Document the latency improvement in the changelog.
| File | Description |
|---|---|
vk-registry/tests/dav_e2e.rs |
Adds a small-object read latency regression test. |
vk-registry/src/lib.rs |
Enables TCP_NODELAY on accepted connections. |
CHANGELOG.md |
Records the small-read latency fix. |
Review effort: Balanced
kurze
force-pushed
the
vk-registry/nodelay
branch
from
November 5, 2026 12:27
a040f34 to
a6e67bb
Compare
A small response goes out as a head write then a body write. With Nagle's algorithm on, the body waits for the client's delayed ACK, about 40 ms on Linux, so every small object or manifest read on a kept-alive connection paid it. A Go build cache over the DAV tree, mostly small entries, read back 3 to 4 times slower than with the option set.
kurze
force-pushed
the
vk-registry/nodelay
branch
from
November 5, 2026 12:29
ef882e1 to
285fec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A small response goes out as a head write then a body write.
With Nagle's algorithm on, the body waits for the client's delayed ACK, about
40 ms on Linux (at least on my env), so every small object or manifest read on a kept-alive connection paid it.
A Go build cache over the DAV tree, mostly small entries, read back 3 to 4 times slower than with the option set.
useful if we want to use vk-registry as compilation cache server too