Repository navigation
slabtop: implement human - #808
Bluemangoo wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #808 +/- ##
==========================================
+ Coverage 19.20% 19.39% +0.19%
==========================================
Files 68 68
Lines 10156 10271 +115
Branches 546 560 +14
==========================================
+ Hits 1950 1992 +42
- Misses 8206 8279 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| uucore = { workspace = true } | ||
| clap = { workspace = true } | ||
|
|
||
| uu_free = { path = "../free" } |
There was a problem hiding this comment.
i am not a fan of a util depending on another util crate.
could you please move humanized to a shared place instead (uucore or a small common module)?
There was a problem hiding this comment.
procps' humanized is different from coreutils' (see #431 )
our common module is on the way #802 , or should I create a new crate for it?
anyway humanized is dependented by 3 utils. I agree that it is necessary to move it in a shared place.
@Krysztal112233 #805 did the same things.
There was a problem hiding this comment.
To avoid finding ourselves in the same situation as uu_pgrep, I agree with moving it to a separate crate.
However, I believe a new pull request should be opened for this purpose.
There was a problem hiding this comment.
And I raised the same matter in #805.
For this pull request, I would prefer to make a copy of humanize and mark it with a TODO
3e8cef2 to
b5331c4
Compare
b5331c4 to
72e7c6c
Compare
|
made a copy of |
72e7c6c to
d18de49
Compare
|
removed the dependency on bytesize and added a small tip to avoid confusion when moving it to a shared crate. I have no idea about the unit test for the formatting. should I add a unit test for the removing 'K'? or duplicate the test for |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
9499407 to
b7fa2c6
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Add human readable option, exactly for CACHE SIZE in both header and table.
Notably, there is a slight format difference between ours and GNU. Anyway, it is unrelated to this PR.
tips: this PR has git conflict with #805
from GNU:
from this PR: