Repository navigation
chore(release): 0.5.1 - #9
Merged
Merged
Conversation
list() wrote the default ignore rules to /tmp/pyo-defaults-<pid>.ignore for the walker. Parallel tests in one process shared that path and raced on it, and on a shared machine a symlink planted at the guessable path made pyo deploy overwrite the file it points to. Build the defaults as an in-memory gitignore instead and apply them in filter_entry. They still rank below .pyoignore, .gitignore and git exclude: a default leaves a path out only when the folder's own ignore files don't whitelist it, checked with an incremental matcher built from the same walk settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pyo 0.5.1: pyo deploy no longer writes its default ignore rules to a predictable file in /tmp, and the version bump.