Repository navigation
fix(parse): preserve empty parameter names - #41
Open
awais-ur-rehman wants to merge 1 commit into
Open
awais-ur-rehman wants to merge 1 commit into
awais-ur-rehman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stringify({ '': 'value' })produces=value, but parsing it currently returns{ value: '' }. The parser requires a nonempty name, so it starts reading at the value instead. Allow an empty name when followed by=so this valid query parameter survives parsing and round-trips through the library.The lookahead only admits an empty name before an equals sign, which is consumed by the match. Empty query separators remain ignored. Tests cover empty names before/between/after named parameters,
?and#prefixes, empty values, duplicate first-value behavior, malformed encoding and the round-trip above.Testing
Validation:
npm test(26 passing, 100% statement/branch/function/line coverage) andgit diff --check, using Node.js 24.19.0. Four new regressions failed before the fix. The project has no separate build or lint command. Its Node.js 14/16/18 CI matrix was not run locally.Assisted by OpenAI Codex for reproduction, implementation and test execution.
Breaking Changes
None.
Manual verification: parse(stringify({'': 'value with spaces', foo: 'bar'})) should preserve both keys and values; empty separators should still be ignored.