Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4660 +/- ##
==========================================
+ Coverage 50.30% 50.41% +0.10%
==========================================
Files 181 181
Lines 30660 30698 +38
==========================================
+ Hits 15424 15476 +52
+ Misses 15236 15222 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timothy-nunn
reviewed
Nov 6, 2026
| @@ -24,6 +24,35 @@ | |||
| from process.models.tfcoil import quench | |||
| from process.models.tfcoil.base import TFCoil, TFPlasmaCaseType | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class _TFStressResults: | |||
Collaborator
There was a problem hiding this comment.
stresscl is defined in base.py so how come we have defined this here?
Collaborator
Author
There was a problem hiding this comment.
Because it was a numba wrapped function. I have done a wrapper, see what you think
| a_tf_turn_steel=self.data.tfcoil.a_tf_turn_steel, | ||
| a_cs_poloidal=self.data.pf_coil.a_cs_poloidal, | ||
| try: | ||
| stress = _TFStressResults( |
Collaborator
There was a problem hiding this comment.
Why don't we return a _TFStressResults from the method itself rather than doing this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
I confirm that I have completed the following checks: