Skip to content

Add support for gitlab v 19 - #1144

Merged
Toa741 merged 8 commits into
mainfrom
add-support-for-gitlab-v19
Sep 16, 2026
Merged

Toa741 merged 8 commits into
mainfrom
add-support-for-gitlab-v19

Conversation

@FBSALOMON

@FBSALOMON FBSALOMON commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor
  • Replaces playwright token generation with gitlab-rails runner executed directly inside GitLab test container
  • GitLab 19 rejects commit creation requests with an empty actions array unless allow_empty=true is set (GitLab added this requirement in 18.8). Added a nullable AllowEmpty property to CommitCreate and set it in the one test that creates an empty commit
  • Fixed GetArchive_QuerySpecifiesAllParameters_AllParametersPassedCorrectly by using the HEAD commit instead of the first commit when combining path=subfolder with a sha, since the subfolder path doesn't exist yet at the first commit. GitLab v18 tolerated this stale path/sha combination (returned an empty folder inside the zip file), but v19 now correctly returns 404 when the requested path doesn't exist at the given revision

@Toa741
Toa741 marked this pull request as ready for review September 16, 2026 17:06
@Toa741
Toa741 requested a review from a team as a code owner September 16, 2026 17:06
@Toa741
Toa741 requested review from louis-z and removed request for a team September 16, 2026 17:06
@Toa741
Toa741 merged commit aca614a into main Sep 16, 2026
9 checks passed
@Toa741
Toa741 deleted the add-support-for-gitlab-v19 branch September 16, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants