Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
treeform
marked this pull request as draft
September 24, 2026 23:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
{.hasSimd.}/{.simd.}macros with plainwhendispatch written directly in each proc.The macro kept a
{.compileTime.}table that one module wrote and another read. That breaks under--ic:on(see guzba/nimsimd#38). With this change, no compile-time state is shared between modules and the dispatch is visible in the source.Each former
hasSimdproc now looks like this:The plain path sits under
else:. A barereturninsidewhenfollowed by more code makes Nim print anUnreachableCodewarning. Most of the diff is that re-indent.Changes
simd.nimdefinesallowSse2,allowAvxandallowNeonnext toallowSimd.{.simd.}pragma and thenimsimd/hassimdimport are removed from the SIMD modules. The SIMD bodies are unchanged.-d:pixieAvx2flag. It turnscpuHasAvxandcpuHasAvx2intoconst true, so builds for a fixed architecture skip the runtime CPU check. Without the flag the runtime check stays as before.Testing
nim checkhas no errors for arm64,-d:pixieNoSimd, amd64, amd64-d:pixieNoAvxand amd64-d:pixieAvx2.tests/tests.nimruns through to the end on arm64 (NEON) and with-d:pixieNoSimd.🤖 Generated with Claude Code