Skip to content

fix: create the table's own namespace for qualified table names - #381

Open
nirmalpatel008 wants to merge 1 commit into
tower:developfrom
nirmalpatel008:fix/create-namespace-from-qualified-name
Open

nirmalpatel008 wants to merge 1 commit into
tower:developfrom
nirmalpatel008:fix/create-namespace-from-qualified-name

Conversation

@nirmalpatel008

Copy link
Copy Markdown

tables() accepts a qualified name such as "sales.orders", and load() resolves it correctly. But create() and create_if_not_exists() always create the default namespace (or the namespace argument), not the namespace in the name. So tables("sales.orders").create(schema) fails with NoSuchNamespaceError: ('sales',), and it leaves an empty default namespace behind. On Glue or S3 Tables, that’s a stray database.

This change creates the namespace taken from the resolved table name instead. Unqualified names behave as before.

Tests: added cases for create and create_if_not_exists with a qualified name and a nested one (analytics.sales.orders). They fail before the change and pass after. Ran the table and storage tests locally with the pinned PyIceberg 0.11.1 and Polars 1.39.3: 130 passed.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@nirmalpatel008

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

tower-cla-app Bot added a commit that referenced this pull request Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant