Repository navigation
Conversation
What was broken Deal details omitted the Work project and billing history for extensions whose billing account differs from the shared project's current account. Root cause The opportunity endpoint only matched Project.billingAccountId and ignored the explicit Salesforce Work/Connect project reference already used by Sales reports. What was changed Read TC_Connect_Project_Id__c and use it to resolve a non-deleted project when no current billing-account match exists. Validate the reference, preserve the opportunity's own account, and reuse the existing project billing history lookup. Update the service documentation, response DTO description, and README. Any added/updated tests Added 17 regression cases covering shared extension projects, account-match precedence, invalid/missing/deleted references, and lookup failures. The extension regressions fail against the previous implementation. All 56 focused API tests and all 6 existing Sales modal tests pass. pnpm lint and pnpm build pass. Full unit and e2e suites were run. Their 15 unit and 8 e2e failures reproduce unchanged on origin/dev (metadata events, JWT handling, event fixtures, and permission-system checks); this change adds no failures.
PM-6579: Resolve shared Work projects for deal extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.