Repository navigation
Conversation
🔀 Cross-SDK feature parityDoes this change need to ship in the other ThunderID SDKs too? This check stays red until one of these labels answers that:
Ports (DO NOT EDIT)
No sibling SDKs accounted for on this thread yet. Important Reply to this comment with this block, filled in. The boxes above tick A link can be a pull request or a tracked issue, written in full or as The contract is in the SDK development specification. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
The E2E nightly job fails when the download of the ThunderID release from GitHub returns a temporary error such as an
HTTP 502. When that happens, no tests run and the nightly is reported as failed even though nothing is wrong with the SDKs.Approach
In
.github/actions/run-e2e-suite/action.yml:npx thunderidup to 3 times. After each try, check whether a release was installed. If not, wait 15s and try again.findcommand from ending the step when thethunderid/folder doesn't exist. The step now prints its own clear error after the last failed try.Only the CI workflow changes. The local
tests/e2e/run-e2e.shscript is not changed.Related Issues
Related PRs
Checklist
breaking changelabel added.parity/prs-raisedorparity/prs-not-neededadded.parity/prs-raised, the port links are posted as a reply on the parity check's comment.Security checks