Repository navigation
Update vite and launch-editor for the launch-editor advisory - #128
Closed
brionmario wants to merge 1 commit into
Closed
brionmario wants to merge 1 commit into
brionmario wants to merge 1 commit into
Conversation
GHSA-587h-7wmj-h5pm lets launch-editor's fs.existsSync() existence check be bypassed on Windows, and pnpm audit --audit-level=high now fails the Security Audit job. Refresh vite to 6.4.4 and 7.3.7 and launch-editor to 2.14.2, raise the React playground's vite floor to the patched 6.4.4, and pin the vite 8 line to 8.2.4, which pnpm otherwise keeps at the locked 8.2.1 for vitest's peer range. Signed-off-by: Brion <info@brionmario.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
Folded into #127, which now carries the vite and launch-editor update for GHSA-587h-7wmj-h5pm. |
6 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
GHSA-587h-7wmj-h5pm (published 2026-10-21) lets launch-editor's
fs.existsSync()existence check be bypassed on Windows.pnpm audit --audit-level=highnow reports it forlaunch-editorandvite, so the Security Audit job fails onmainand on every pull request (for example #127).vite6.x@nuxt/test-utils,playgrounds/reactvite7.xnuxt>@nuxt/vite-buildervite8.x@thunderid/eslint-plugin>@vitest/eslint-plugin>vitestlaunch-editor@nuxt/devtoolsApproach
Following the repository's advisory workflow, try the update first and fall back to a pin:
pnpm update -r --depth Infinity vite launch-editormoves vite 6 and 7 and launch-editor onto their patched releases, all within the ranges their parents already declare. It also raisesplaygrounds/react'svitefloor to^6.4.4.vitest's peer range.vitestalready permits 8.2.4, but pnpm keeps the peer at the locked 8.2.1 throughpnpm updateandpnpm dedupe. Updating it explicitly instead rewrote the React playground's range to a new major. Sopnpm-workspace.yamlpinsvite@8: 8.2.4with a justification that says when to drop it, matching the existingbrace-expansion@5style pins.Version changes in the lockfile: only
vite,launch-editor, androlldown1.2.3 → 1.2.14 with its platform bindings and@oxc-project/types, which vite 8.2.4 requires.Verified locally:
pnpm audit --audit-level=highpasses; only the advisories the workspace already ignores remain.pnpm install --frozen-lockfile,pnpm build(14/14),pnpm format:check,pnpm test, and the PR builder's lint all pass.pnpm lintacrosspackages/already fails onmain(packages/expressno-unsafe-*errors) and isn't part of CI.Related Issues
Related PRs
Checklist
breaking changelabel added.parity/prs-raisedorparity/prs-not-neededadded.parity/prs-raised, the port links are posted as a reply on the parity check's comment.Security checks