Repository navigation
Conversation
Add explicit direction "capture" to the pipeline."1" scheduler widget in
dai-copier-eqiir-module-copier-capture.conf, host-gateway-capture.conf,
and webrtc-{aec,ns,ns2}-capture.conf so the pipeline widget direction
matches the enclosing capture pipeline class.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Add AEC_PROCESSING support to cavs-mixin-mixout-hda.conf to insert
webrtc-aec.3.1 into the HDA analog capture path (module-copier.4.2 ->
webrtc-aec.3.1 -> host-copier.0.capture) with runtime ALSA switch
controls ('Pre Mixer Analog Capture AEC Switch' and
'Pre Mixer Analog Capture AEC Suppression Switch').
Register the sof-hda-generic-webrtc-aec development topology target in
tplg-targets.cmake.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Instantiate webrtc-hpf (DC/<80 Hz removal) and webrtc-agc (digital gain
control and saturation limiter) in webrtc-ns-capture.conf alongside
webrtc-vad and webrtc-ns to form the complete WebRTC voice
pre-processing chain.
Add PTL nocodec topology targets (sof-ptl-nocodec-webrtc-{ns,aec,ns2})
in tplg-targets.cmake alongside the existing TGL targets.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The HDA AEC lacks a playback-reference input needed to cancel speaker echo, and its default suppression control name exceeds ALSA topology’s 43-byte name limit.
2 open issues
What changed in this PR
This PR extends topology2’s WebRTC capture processing and adds development targets for HDA and Panther Lake.
Changes:
- Sets explicit capture direction on five pipeline scheduler widgets.
- Adds HPF and AGC stages to the existing VAD/NS capture chain.
- Adds an optional HDA AEC capture path and registers HDA AEC and PTL WebRTC targets.
| File | Description |
|---|---|
tools/topology/topology2/include/pipelines/cavs/webrtc-ns2-capture.conf |
Sets capture scheduler direction. |
tools/topology/topology2/include/pipelines/cavs/webrtc-ns-capture.conf |
Adds HPF/AGC widgets and routes; sets capture direction. |
tools/topology/topology2/include/pipelines/cavs/webrtc-aec-capture.conf |
Sets capture scheduler direction. |
tools/topology/topology2/include/pipelines/cavs/host-gateway-capture.conf |
Sets capture scheduler direction. |
tools/topology/topology2/include/pipelines/cavs/dai-copier-eqiir-module-copier-capture.conf |
Sets capture scheduler direction. |
tools/topology/topology2/development/tplg-targets.cmake |
Registers PTL NS, NS2, and AEC targets plus HDA AEC. |
tools/topology/topology2/development/cavs-nocodec-webrtc-ns.conf |
Updates comments and diagram for the expanded capture chain. |
tools/topology/topology2/cavs-mixin-mixout-hda.conf |
Adds optional AEC widget, controls, and analog capture routing. |
Review effort: Balanced
Comment on lines
+456
to
+457
| num_input_pins 1 | ||
| num_input_audio_formats 1 |
| name 'Pre Mixer $ANALOG_CAPTURE_PCM AEC Switch' | ||
| } | ||
| mixer."2" { | ||
| name 'Pre Mixer $ANALOG_CAPTURE_PCM AEC Suppression Switch' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up topology2 improvements for the WebRTC audio processing module suite (#11044, #11419):
topology2: add missing direction attribute to capture pipelinesdirection "capture"to thepipeline."1"scheduler widget indai-copier-eqiir-module-copier-capture.conf,host-gateway-capture.conf, andwebrtc-{aec,ns,ns2}-capture.confso the pipeline widget direction matches the enclosing capture pipeline class.topology2: cavs-mixin-mixout-hda: add WebRTC AEC capture supportAEC_PROCESSINGflag tocavs-mixin-mixout-hda.confthat insertswebrtc-aec.3.1betweenmodule-copier.4.2andhost-copier.0.captureon the analog capture path, and registersof-hda-generic-webrtc-aecindevelopment/tplg-targets.cmake.topology2: wire webrtc-hpf and webrtc-agc into capture and add PTLwebrtc-hpfandwebrtc-agcintowebrtc-ns-capture.conf(dai-copier -> webrtc-hpf -> webrtc-vad -> webrtc-ns -> webrtc-agc -> host-copier) and addwebrtc-hpfpre-filtering ahead ofwebrtc-ns2inwebrtc-ns2-capture.conf.sof-ptl-nocodec-webrtc-{ns,ns2,aec}indevelopment/tplg-targets.cmake.